Attention is currently required from: Philipp Deppenwiese, Michał Żygowski, Paul Menzel, Piotr Król.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54641 )
Change subject: tpm: Remove USER_TPMx options, make TPM1/TPM2 menuconfig visible
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54641/comment/79fe9bc5_95781069
PS3, Line 19: Also fix some mainboards that selected TPM2 directly, which they're not
: supposed to do (that's what MAINBOARD_HAS_TPM2 is for), and add a
: missing dependency to TPM_CR50 so it is set correctly for a NO_TPM
: scenario.
It’d be great if you split this into a separate commit.
Let's please not make things too complicated, I don't want to reshuffle both my and Kyösti's patch just for that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54641
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0a73da3c42fa4e8deffecb53f29ee38cbb51a93
Gerrit-Change-Number: 54641
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Thu, 27 May 2021 22:01:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment