[S] Change in coreboot[master]: mb/google/brya: add ACPI brightness controls for iGPU - coreboot-gerrit

3 Sep 2023


      Attention is currently required from: Angel Pons, Eric Lai, Kangheui Won, Martin L Roth.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70372?usp=email )
Change subject: mb/google/brya: add ACPI brightness controls for iGPU
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/70372/comment/ce10c4f0_de0a0420 :
PS2, Line 110: 			register "gfx" = "GMA_DEFAULT_PANEL(0)"
...
Since this is a literal, you could do something like this: […]
I'll try that, but with the values reversed
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/70372?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03bb7a7309476839c49d2e862a036d9e89800605
Gerrit-Change-Number: 70372
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Kwongnin Tin kwongnint@gmail.com
Gerrit-Reviewer: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Kangheui Won khwon@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Sun, 03 Sep 2023 15:31:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth gaumless@gmail.com
Gerrit-MessageType: comment