Change in coreboot[master]: src/southbridge/intel/common/firmware: Add 10GbE LAN firmware
Attention is currently required from: Felix Singer, Paul Menzel, Angel Pons, Patrick Rudolph. Jeff Daly has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60877 )
Change subject: src/southbridge/intel/common/firmware: Add 10GbE LAN firmware ......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60877/comment/8ea3c6d2_754f1fe2 PS4, Line 7: Add 10GbE LAN firmware
I thought you are adding the firmware files. ;-) Maybe: […]
this brings up a potential issue.... i think usually the firmware for the LAN stuff is something that isn't generally available. and the LAN firmware (or at least the settings are specific to the platform implementation. one binary isn't for every platform. i'll see if there's a path to getting the binaries posted someplace where they can be fetched during the build
Patchset:
PS4:
You also need to specify `IFD_CHIPSET` in Denverton-NS Kconfig.
what i'd like to avoid is adding this functionality to the code to codebase that i'm moving DNV away from. meaning, i understand that adding the ability to specify the IFD stuff for DNV can also apply to the current state of the code, but since i'm focused on the refactoring, i don't care whether the IFD stuff is used by the current state of it or not. If someone wants to pull this patch into their current codebase and enable it via the denverston_ns/Kconfig, great but i don't feel like it's specifically up to me to make sure the pre-refactor code uses it. the older stuff should still build fine without it.
does that make sense?
File src/southbridge/intel/common/firmware/Kconfig:
https://review.coreboot.org/c/coreboot/+/60877/comment/4b1acb35_05c2a3a7 PS2, Line 171: HAVE_10GB_2_BIN
I understand your frustration, DNV-NS hasn't seen much upstream development so navigating through th […]
i've done the renaming and pushed, so check the current patchset
-
Jeff Daly (Code Review)