Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/17573 )
Change subject: nvramtool: Change binary install directory from sbin to bin
......................................................................
Patch Set 3:
Patch Set 3:
I think we pretty much expect $(INSTALL) to be gnu, so maybe use -D instead of mkdir?
I can do that in a follow-up commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/17573
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5febccf07c0313ed2f1f60142fc76e9c9a4dc27
Gerrit-Change-Number: 17573
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Kocialkowski
contact@paulk.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Kocialkowski
contact@paulk.fr
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Denis 'GNUtoo' Carikli
GNUtoo@cyberdimension.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Thu, 03 Oct 2019 08:26:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment