Attention is currently required from: V Sowmya, Sugnan Prabhu S, Rizwan Qureshi, Aamir Bohra, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51274 )
Change subject: soc/intel/alderlake/acpi: Skip D3Cold for TBT
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51274/comment/171c4c28_a92b2e8f
PS3, Line 9: Includes change to skip D3Cold when TBT is in disconnected state which
: was blocking the S0ix state transition.
Is this a temporary fix? Or an expected behavior i.e. skip D3 cold when TBT is in disconnected state? If this is an expected change, can you please provide more information about why it is required? IIUC, the state is that the TBT controller is enabled, but it is not being put into D3 state if there is no device connected downstream?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51274
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9b9ceee4393aeba37fdcb4e05d1b279a6ff72d2
Gerrit-Change-Number: 51274
Gerrit-PatchSet: 3
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 23 Mar 2021 00:08:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment