Attention is currently required from: Kevin Keijzer.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73451 )
Change subject: mb/asrock/b75pro3-m: Add CMOS layout/defaults and vbt.bin ......................................................................
Patch Set 2: Code-Review+1
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73451/comment/9cd05163_d5e627cd PS2, Line 9: was lacking It’d use present tense to describe the current situation: lacks.
https://review.coreboot.org/c/coreboot/+/73451/comment/d2e93963_6cb8a8ef PS2, Line 10: could not Ditto.
https://review.coreboot.org/c/coreboot/+/73451/comment/6afd23eb_2d8d064a PS2, Line 13: I have "borrowed" the files from the similar h77pro4-m port, which : work fine for the b75pro3-m. I can now adjust things like gfx_uma_size : and power_on_after_fail, which are quite useful to be able to modify. I’d write: Borrow the files from …. Now it’s possible to adjust ….
https://review.coreboot.org/c/coreboot/+/73451/comment/505a8154_1b69b47a PS2, Line 18: VGABIOS Which version.
Patchset:
PS2: Thank you for this improvements. I only have some commit message nit picks.