Change in coreboot[master]: vc/intel/fsp/fsp2_0/cpx_sp: Add DIMM present field and max memory spe... - coreboot-gerrit

1 Oct 2020


      Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45797 )
Change subject: vc/intel/fsp/fsp2_0/cpx_sp: Add DIMM present field and max memory speed function
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45797/4/src/vendorcode/intel/fsp/fs... 
File src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/memory.h:
https://review.coreboot.org/c/coreboot/+/45797/4/src/vendorcode/intel/fsp/fs... 
PS4, Line 47: uint16_t get_max_memory_speed(uint32_t commonTck)
Why is this defined inside the header?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/45797
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I988e7341ddd3b701c698b41451a87890f21cc928
Gerrit-Change-Number: 45797
Gerrit-PatchSet: 4
Gerrit-Owner: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam anjaneya.chagam@intel.com
Gerrit-Reviewer: Isaac W Oram isaac.w.oram@intel.com
Gerrit-Reviewer: Jingle Hsu jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Nathaniel L Desimone nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Thu, 01 Oct 2020 20:46:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment