Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Shuo Liu, Tim Chu.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81349?usp=email )
Change subject: soc/intel/xeon_sp: Remove PAM lock and unlock operations
......................................................................
Patch Set 13:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81349/comment/3f957eb2_d48a3764 :
PS13, Line 11: some SoCs
which ones?
File src/soc/intel/xeon_sp/util.c:
https://review.coreboot.org/c/coreboot/+/81349/comment/992620ab_59962f40 :
PS5, Line 115: lock_pam0123
In UEFI (in bootloader and in FSP), CPX/SKX need the lock, but SPR doesn't need nor do the lock. […]
This doesn't answer the question.
Does SPR FSP always lock it by default? If yes please update the commit message and made clear which FSP does what.
Reading FSP source it looks like LockChipset is always 0, thus SPR FSP would not lock it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81349?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3fd1d806807449e6a4d9d4d2c8a47ce61ed53018
Gerrit-Change-Number: 81349
Gerrit-PatchSet: 13
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Sat, 30 Mar 2024 08:17:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com
Gerrit-MessageType: comment