Attention is currently required from: Arthur Heymans, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76515?usp=email )
Change subject: vendorcode/amd/opensil: Add initial setup and API calls
......................................................................
Patch Set 8: Code-Review+2
(2 comments)
File src/vendorcode/amd/opensil/genoa_poc/ramstage.c:
https://review.coreboot.org/c/coreboot/+/76515/comment/fa7af880_cf0d34fa :
PS7, Line 14: error_string
might be good to rename this struct to avoid confusion. […]
Done
https://review.coreboot.org/c/coreboot/+/76515/comment/69ba4cb6_e6e3ba5f :
PS7, Line 86: /* TODO Find a better place for BOOT_STATE_INIT_ENTRY */
maybe reword this to something like: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76515?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4833a5a86034a13e6be102a6b68c3bb54108bc9a
Gerrit-Change-Number: 76515
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 05 Dec 2023 15:46:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment