[XS] Change in coreboot[main]: lib/fw_config: Avoid negative bit shift

[Julius Werner (Code Review)]

Attention is currently required from: Martin L Roth.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78620?usp=email )

Change subject: lib/fw_config: Avoid negative bit shift
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:
> It's one compare, not a bunch of code to check it. […]

I mean... I'd say checking in code that tests for something which can't happen is a waste of time?

I was here reviewing this code when it was written. I remember thinking about this part and concluding that a check was unnecessary. It's just odd to then suddenly reverse that decision later only because a random tool that doesn't have as much context as the people who wrote and reviewed this code said so.

I think linters and static analyzers are great to point out things that may have been overlooked, but we should remember that they're just that... reminders to take another look.