Change in ...coreboot[master]: src/security: Remove not used #include <fmap.h>

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in ...coreboot[master]:...

HAOUAS Elyes (Code Review)

23 Jun 2019 23 Jun '19

11:41 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33734

Change subject: src/security: Remove not used #include <fmap.h> ......................................................................

src/security: Remove not used #include <fmap.h>

Change-Id: I9db59d5db2ed3e792251a94b67fb277d9160e4e8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/security/tpm/tspi/log.c M src/security/vboot/vboot_handoff.c 2 files changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/33734/1

diff --git a/src/security/tpm/tspi/log.c b/src/security/tpm/tspi/log.c index 6ab9067..a33116a 100644 --- a/src/security/tpm/tspi/log.c +++ b/src/security/tpm/tspi/log.c @@ -16,7 +16,6 @@ #include <console/console.h> #include <security/tpm/tspi.h> #include <arch/early_variables.h> -#include <fmap.h> #include <region_file.h> #include <string.h> #include <security/vboot/symbols.h> diff --git a/src/security/vboot/vboot_handoff.c b/src/security/vboot/vboot_handoff.c index 19773c54..d8af702 100644 --- a/src/security/vboot/vboot_handoff.c +++ b/src/security/vboot/vboot_handoff.c @@ -26,7 +26,6 @@ #include <cbmem.h> #include <console/console.h> #include <console/vtxprintf.h> -#include <fmap.h> #include <stdlib.h> #include <vboot_struct.h> #include <security/vboot/vbnv.h>

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Paul Menzel (Code Review)

24 Jun 24 Jun

12:45 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33734 )

Change subject: src/security: Remove not used #include <fmap.h> ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/33734/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/33734/1//COMMIT_MSG@7 PS1, Line 7: not used unused

-- To view, visit https://review.coreboot.org/c/coreboot/+/33734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9db59d5db2ed3e792251a94b67fb277d9160e4e8 Gerrit-Change-Number: 33734 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 24 Jun 2019 10:45:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

2 Jul 2 Jul

3:50 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33734 )

Change subject: src/security: Remove not used #include <fmap.h> ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33734/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/33734/1//COMMIT_MSG@7 PS1, Line 7: not used

...

unused

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/33734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9db59d5db2ed3e792251a94b67fb277d9160e4e8 Gerrit-Change-Number: 33734 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 02 Jul 2019 13:50:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

3:50 p.m.

New subject: Change in ...coreboot[master]: src/security: Remove unused #include <fmap.h>

Hello Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33734

to look at the new patch set (#2).

Change subject: src/security: Remove unused #include <fmap.h> ......................................................................

src/security: Remove unused #include <fmap.h>

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/33734/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9db59d5db2ed3e792251a94b67fb277d9160e4e8 Gerrit-Change-Number: 33734 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

4:02 p.m.

New subject: Change in ...coreboot[master]: src/security: Remove unused #include <fmap.h>

Hello Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33734

to look at the new patch set (#3).

Change subject: src/security: Remove unused #include <fmap.h> ......................................................................

src/security: Remove unused #include <fmap.h>

Change-Id: I9db59d5db2ed3e792251a94b67fb277d9160e4e8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/security/tpm/tspi/log.c 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/33734/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/33734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9db59d5db2ed3e792251a94b67fb277d9160e4e8 Gerrit-Change-Number: 33734 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

15 Sep 15 Sep

10:42 p.m.

New subject: Change in coreboot[master]: src/security: Remove unused #include <fmap.h>

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33734 )

Change subject: src/security: Remove unused #include <fmap.h> ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9db59d5db2ed3e792251a94b67fb277d9160e4e8 Gerrit-Change-Number: 33734 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 15 Sep 2019 20:42:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

10:42 p.m.

New subject: Change in coreboot[master]: src/security: Remove unused #include <fmap.h>

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33734 )

Change subject: src/security: Remove unused #include <fmap.h> ......................................................................

src/security: Remove unused #include <fmap.h>

Change-Id: I9db59d5db2ed3e792251a94b67fb277d9160e4e8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33734 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/security/tpm/tspi/log.c 1 file changed, 0 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

diff --git a/src/security/tpm/tspi/log.c b/src/security/tpm/tspi/log.c index 99e6a43..9986d9a 100644 --- a/src/security/tpm/tspi/log.c +++ b/src/security/tpm/tspi/log.c @@ -16,7 +16,6 @@ #include <console/console.h> #include <security/tpm/tspi.h> #include <arch/early_variables.h> -#include <fmap.h> #include <region_file.h> #include <string.h> #include <security/vboot/symbols.h>

-- To view, visit https://review.coreboot.org/c/coreboot/+/33734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9db59d5db2ed3e792251a94b67fb277d9160e4e8 Gerrit-Change-Number: 33734 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1683

days inactive

1767

days old

coreboot-gerrit@coreboot.org

6 comments

3 participants

tags (0)

participants (3)

HAOUAS Elyes (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)