Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Sean Rhodes, Subrata Banik.
Angel Pons has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/81906?usp=email )
Change subject: soc/intel/alderlake: Hook up PCIe Power Management to option API
......................................................................
Patch Set 10: Code-Review+2
(2 comments)
Patchset:
PS10:
Technically you
Commit Message:
https://review.coreboot.org/c/coreboot/+/81906/comment/c4efe55c_99aa3213?usp... :
PS10, Line 10: option API.
Ideally, you would want to have per-port options. But I understand that this is not practical given how limited CMOS space is. I would prefer to add a note here describing this limitation.
Alternatively, if you have the root port number, you could complicate things and use `sprintf()` to append the root port number (also differentiate between CPU and PCH RPs). Then, you can just define the options you care about in the CMOS layout (e.g. in-use RPs of a mainboard).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81906?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2b06a7c734a4fd4073e86c668742ee35e1d79956
Gerrit-Change-Number: 81906
Gerrit-PatchSet: 10
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Wed, 02 Oct 2024 14:31:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes