New patch to review for coreboot: 8240f58 northbridge: DEVICE_NOOP some stub function callbacks
Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7344
-gerrit
commit 8240f58f36f1daf99af2c77e0122c8eea7b8d054 Author: Edward O'Callaghan eocallaghan@alterapraxis.com Date: Thu Nov 6 08:57:40 2014 +1100
northbridge: DEVICE_NOOP some stub function callbacks
Reduces loc and makes NOP's explicit.
Change-Id: I8a117b150b8b421c7a18b48a2ac36d15679f20b0 Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com --- src/northbridge/amd/agesa/family14/northbridge.c | 12 ++---------- src/northbridge/amd/agesa/family15/northbridge.c | 12 ++---------- src/northbridge/amd/agesa/family15tn/northbridge.c | 12 ++---------- src/northbridge/amd/amdfam10/northbridge.c | 6 +----- 4 files changed, 7 insertions(+), 35 deletions(-)
diff --git a/src/northbridge/amd/agesa/family14/northbridge.c b/src/northbridge/amd/agesa/family14/northbridge.c index d7a352b..f8464c8 100644 --- a/src/northbridge/amd/agesa/family14/northbridge.c +++ b/src/northbridge/amd/agesa/family14/northbridge.c @@ -779,14 +779,6 @@ static void domain_enable_resources(struct device *dev)
/* Bus related code */
-static void cpu_bus_read_resources(struct device *dev) -{ -} - -static void cpu_bus_set_resources(struct device *dev) -{ -} - static u32 cpu_bus_scan(struct device *dev, u32 max) { struct bus *cpu_bus = dev->link_list; @@ -846,8 +838,8 @@ static struct device_operations pci_domain_ops = { };
static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_read_resources, - .set_resources = cpu_bus_set_resources, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, .enable_resources = NULL, .init = cpu_bus_init, .scan_bus = cpu_bus_scan, diff --git a/src/northbridge/amd/agesa/family15/northbridge.c b/src/northbridge/amd/agesa/family15/northbridge.c index 2d69939..2b0b8b8 100644 --- a/src/northbridge/amd/agesa/family15/northbridge.c +++ b/src/northbridge/amd/agesa/family15/northbridge.c @@ -1092,17 +1092,9 @@ static void cpu_bus_init(struct device *dev) initialize_cpus(dev->link_list); }
-static void cpu_bus_read_resources(struct device *dev) -{ -} - -static void cpu_bus_set_resources(struct device *dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_read_resources, - .set_resources = cpu_bus_set_resources, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = cpu_bus_scan, diff --git a/src/northbridge/amd/agesa/family15tn/northbridge.c b/src/northbridge/amd/agesa/family15tn/northbridge.c index 1fccec1..5c650f3 100644 --- a/src/northbridge/amd/agesa/family15tn/northbridge.c +++ b/src/northbridge/amd/agesa/family15tn/northbridge.c @@ -1054,17 +1054,9 @@ static void cpu_bus_init(struct device *dev) initialize_cpus(dev->link_list); }
-static void cpu_bus_read_resources(struct device *dev) -{ -} - -static void cpu_bus_set_resources(struct device *dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_read_resources, - .set_resources = cpu_bus_set_resources, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = cpu_bus_scan, diff --git a/src/northbridge/amd/amdfam10/northbridge.c b/src/northbridge/amd/amdfam10/northbridge.c index 779a0d6..e49deec 100644 --- a/src/northbridge/amd/amdfam10/northbridge.c +++ b/src/northbridge/amd/amdfam10/northbridge.c @@ -1412,10 +1412,6 @@ static void cpu_bus_init(struct device *dev) }
-static void cpu_bus_read_resources(struct device *dev) -{ -} - static void cpu_bus_set_resources(struct device *dev) { struct resource *resource = find_resource(dev, 0xc0010058); @@ -1426,7 +1422,7 @@ static void cpu_bus_set_resources(struct device *dev) }
static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_read_resources, + .read_resources = DEVICE_NOOP, .set_resources = cpu_bus_set_resources, .enable_resources = DEVICE_NOOP, .init = cpu_bus_init,
-
Edward O'Callaghan