Attention is currently required from: Jan Philipp Groß, Nicholas Chin.
Angel Pons has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/86006?usp=email )
Change subject: mb/asrock/fatal1ty_z87_professional: Update devicetree ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86006/comment/09e75141_3561148b?usp... : PS1, Line 9: Add various previously missing settings as well as a few devices,
Is there any user visible change by this?
The added `register` values (from autoport) make this port more complete but shouldn't have a noticeable impact.
@Jan how was this change tested?
File src/mainboard/asrock/fatal1ty_z87_professional/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/86006/comment/aef0aa1b_50f9728f?usp... : PS1, Line 4: register "gpu_ddi_e_connected" = "1" Hmmm, didn't we say this board doesn't have VGA?
-
Angel Pons (Code Review)