Attention is currently required from: Philipp Hug, Furquan Shaikh, Julius Werner, ron minnich.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49336 )
Change subject: cbfs: Remove prog_locate() for payloads (SELF and FIT)
......................................................................
Patch Set 16: Code-Review+2
(1 comment)
File src/lib/selfboot.c:
https://review.coreboot.org/c/coreboot/+/49336/comment/0b92de3c_8be93183
PS16, Line 136: return 0;
Could you please add a comment here that this indicates an optional check? That way it's clearer to the casual reader. I saw the comment in header file, but I think it could be easier to grok w/ a comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49336
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I582b37f36fe6f9f26975490a823e85b130ba49a2
Gerrit-Change-Number: 49336
Gerrit-PatchSet: 16
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Tue, 16 Mar 2021 22:00:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment