Attention is currently required from: Martin L Roth, Subrata Banik, Rizwan Qureshi, Krishna P Bhat D, Ronak Kanabar.
Harsha B R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70227 )
Change subject: src/ec/intel: Create common code for board_id implementation
......................................................................
Patch Set 2:
(2 comments)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/70227/comment/8c192e8b_23b425fe
PS1, Line 83: y
CONFIG(EC_ACPI)
Done
File src/ec/intel/board_id.h:
https://review.coreboot.org/c/coreboot/+/70227/comment/38376606_28c388d7
PS1, Line 6: /*
: * Returns board_id
: */
use single line commenting style
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70227
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If133f6a72b8c3e1d8811a11f91e4556beb8c16e0
Gerrit-Change-Number: 70227
Gerrit-PatchSet: 2
Gerrit-Owner: Harsha B R
harsha.b.r@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-CC: Usha P
usha.p@intel.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Comment-Date: Thu, 01 Dec 2022 17:46:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment