Change in ...coreboot[master]: drivers/intel/fsp2_0: Enable FSP feature to make use of same stack wi... - coreboot-gerrit

27 Mar 2019


      Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32079 )
Change subject: drivers/intel/fsp2_0: Enable FSP feature to make use of same stack with bootloader
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32079/2/src/drivers/intel/fsp2_0/memory_init... 
File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/#/c/32079/2/src/drivers/intel/fsp2_0/memory_init... 
PS2, Line 175: 		arch_upd->StackBase = (void *)_car_stack_start;
Commit description needs more elaboration. Is this just correcting something wrong that is informative?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/32079
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I673b4216d991d8ccad725c3931006a694184106c
Gerrit-Change-Number: 32079
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Mar 2019 20:33:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment