Change in ...coreboot[master]: G505S AtomBIOS ROMs: known good binaries with a script to check their...

List overview All Threads
Download

newer

older

Change in coreboot[master]: G505S...

Change in coreboot[master]:...

Mike Banon (Code Review)

29 Jun 2019 29 Jun '19

6:12 p.m.

Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33886

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256

This change is a mirror for the known good AMD Lenovo G505S AtomBIOS ROMs from this repository - https://github.com/g505s-opensource-researcher/g505s-atombios - with the addition of two ROMs for ASUS AM1I-A and A88XM-E boards that I have.

AtomBIOS ROMs are required to enable the integrated and discrete VGA adapters, however to add the discrete GPU support you will also need to apply these patches: https://review.coreboot.org/c/coreboot/+/33874 - CB:33874 = CB:31448 + CB:31450 G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches

Save to ./coreboot/ then run ./extract_atombios_roms.sh and ./check... . Could analyze these ROMs with AtomDis - https://cgit.freedesktop.org/~mhopf/AtomDis/ Three ROMs are suitable for Lenovo G505S with A10-5750M APU installed, and two as a bonus: for ASUS AM1I-A with Athlon-5370 APU (iGPU HD-8400 / R3-Series) and for ASUS A88XM-E with A10-6700 APU installed (iGPU HD-8670D).

Here are the SHA256 checksums for these AtomBIOS ROMs:

6104e6989ea3f494d7bfa30573bf38e830f1068bab9980caec5e890e0ccbfced ./pci1002,990b.rom - G505S (A10-5750M APU): for integrated GPU (iGPU) HD-8650G 6052b5def3fda2a93f6c4d55ec91b819429e212e26cdb8e0fcca54599c9c92ed ./pci1002,6663.rom - G505S (A10-5750M APU): for discrete GPU (dGPU) HD-8570M 15d74515332bc512de66e0dc910d8600aeb134bf715bbc34a4faac0257f4a0dc ./pci1002,6665.rom - G505S (A10-5750M APU): for discrete GPU (dGPU) R5-M230 cf5ad6f562cda07c8455a5fd33aae49ee6f451561a758e9761d1788767348115 ./pci1002,9830.rom - ASUS AM1I-A (Athlon-5370 APU): for iGPU HD-8400 / R3-Series 73d52887c5c0797a00c38ff1d26528f32620efe41b47c592aa295f008712d0e5 ./pci1002,990c.rom - ASUS A88XM-E (A10-6700 APU): for iGPU HD-8670D

pci1002,990b.rom (for iGPU HD-8650G) has been taken from G505S with R5-M230, and despite the tiny voltage difference - it's working great for all G505S versions. https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/ GZNWISLFHUTYN6C7RTWSQUMJIFOUHMED/

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I717128b279bfaa5164fe6ac7dbfdb64e2984b550 --- A check_atombios_roms.sh A extract_atombios_roms.sh A pci1002,6663.rom.txt A pci1002,6665.rom.txt A pci1002,9830.rom.txt A pci1002,990b.rom.txt A pci1002,990c.rom.txt A sha256sums_atombios_correct.txt 8 files changed, 15,719 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/33886/1

Attachments:

attachment.htm (text/html — 3.9 KB)

Show replies by date

build bot (Jenkins) (Code Review)

29 Jun 29 Jun

6:13 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33886 )

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

Patch Set 1:

(92 comments)

https://review.coreboot.org/#/c/33886/1/pci1002%2C6663.rom.txt File pci1002,6663.rom.txt:

https://review.coreboot.org/#/c/33886/1/pci1002%2C6663.rom.txt@10 PS1, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a500 00c6 cc20 .>x...X@,...... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6663.rom.txt@19 PS1, Line 19: 00000120: 6368 6c61 6e64 2020 2020 2020 2020 2020 chland trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6663.rom.txt@20 PS1, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6663.rom.txt@332 PS1, Line 332: 000014b0: 2366 25ff ff00 0066 3bc8 7321 32db eb20 #f%....f;.s!2.. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6663.rom.txt@372 PS1, Line 372: 00001730: 8acd b502 e801 1db1 028d 9c48 01e8 b520 ...........H... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6663.rom.txt@418 PS1, Line 418: 00001a10: 1e24 70c0 e804 8ae8 e85b ff59 5f5d c320 .$p......[.Y_]. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6663.rom.txt@457 PS1, Line 457: 00001c80: 0ac0 7526 8d9c 4c01 66b8 c409 0000 e820 ..u&..L.f...... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6663.rom.txt@621 PS1, Line 621: 000026c0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6663.rom.txt@872 PS1, Line 872: 00003670: 015e c332 c0c3 6650 532e 8b1e 1602 b220 .^.2..fPS...... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6663.rom.txt@1271 PS1, Line 1271: 00004f60: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6663.rom.txt@1544 PS1, Line 1544: 00006070: ff00 0002 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6663.rom.txt@1549 PS1, Line 1549: 000060c0: 0300 0000 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6663.rom.txt@1571 PS1, Line 1571: 00006220: 910a 0820 0000 0392 0a09 2600 0103 0420 ... ......&.... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6663.rom.txt@1658 PS1, Line 1658: 00006790: 8c04 0100 cdd0 3010 0000 0000 0821 4420 ......0......!D trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6663.rom.txt@1686 PS1, Line 1686: 00006950: 141e 0640 2080 00c0 0000 0000 0d0d 2020 ...@ ......... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6663.rom.txt@1729 PS1, Line 1729: 00006c00: 4080 1020 9d03 4000 1020 b603 4080 0020 @.. ..@.. ..@.. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6663.rom.txt@2010 PS1, Line 2010: 00007d90: ffff ff00 2105 410a 0000 0056 0041 0320 ....!.A....V.A. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6663.rom.txt@2094 PS1, Line 2094: 000082d0: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6665.rom.txt File pci1002,6665.rom.txt:

https://review.coreboot.org/#/c/33886/1/pci1002%2C6665.rom.txt@10 PS1, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a501 00c6 cc20 .>x...X@,...... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6665.rom.txt@19 PS1, Line 19: 00000120: 6e64 2020 2020 2020 2020 2020 2020 2020 nd trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6665.rom.txt@20 PS1, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6665.rom.txt@36 PS1, Line 36: 00000230: 0000 8003 4000 290f 0080 0000 414d 4420 ....@.).....AMD trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6665.rom.txt@542 PS1, Line 542: 000021d0: b822 06e8 eeff c3b8 3f06 e8e7 ffc3 b820 ."......?...... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6665.rom.txt@756 PS1, Line 756: 00002f30: fa15 7507 b501 bb18 00eb 0b80 fa14 7520 ..u...........u trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6665.rom.txt@1487 PS1, Line 1487: 00005ce0: 0000 0000 00c3 0100 0000 0006 3075 0020 ............0u. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6665.rom.txt@1659 PS1, Line 1659: 000067a0: 4000 1020 b603 4080 0020 cf03 4000 0020 @.. ..@.. ..@.. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6665.rom.txt@1702 PS1, Line 1702: 00006a50: 0324 4114 0015 0541 0601 0a0a 1541 0320 .$A....A.....A. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6665.rom.txt@1726 PS1, Line 1726: 00006bd0: 5044 0828 0040 3071 0920 0800 0075 0920 PD.(.@0q. ...u. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6665.rom.txt@1780 PS1, Line 1780: 00006f30: 1f49 0e00 0725 eb09 fe01 252b 0801 5420 .I...%....%+..T trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6665.rom.txt@1823 PS1, Line 1823: 000071e0: 0125 f705 015b 7a28 0025 0000 0049 2020 .%...[z(.%...I trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C6665.rom.txt@2025 PS1, Line 2025: 00007e80: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C9830.rom.txt File pci1002,9830.rom.txt:

https://review.coreboot.org/#/c/33886/1/pci1002%2C9830.rom.txt@13 PS1, Line 13: 000000c0: 6572 6963 2056 4249 4f53 2020 2020 2020 eric VBIOS trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C9830.rom.txt@14 PS1, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C9830.rom.txt@15 PS1, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C9830.rom.txt@125 PS1, Line 125: 000007c0: 0a2c 46fe c975 f48a c559 c302 0104 0820 .,F..u...Y..... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C9830.rom.txt@229 PS1, Line 229: 00000e40: c3bb 0600 e87d 248a c880 e110 d0e9 a820 .....}$........ trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C9830.rom.txt@292 PS1, Line 292: 00001230: 741b e8fb 04e8 1b20 7408 8b56 04e8 1320 t...... t..V... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C9830.rom.txt@773 PS1, Line 773: 00003040: 7d32 c080 ee21 80fa 1e74 15b0 0280 fa20 }2...!...t..... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C9830.rom.txt@1010 PS1, Line 1010: 00003f10: fe8c d08e c026 8b7c 268a 4501 32e4 b920 .....&.|&.E.2.. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C9830.rom.txt@1483 PS1, Line 1483: 00005ca0: 1f53 66bb 401c 001c e8f0 c4be 001c b020 .Sf.@.......... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C9830.rom.txt@2270 PS1, Line 2270: 00008dd0: c32e 8e1e 1503 890e 6004 8ac5 2460 a820 ........`...$`. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C9830.rom.txt@2918 PS1, Line 2918: 0000b650: 0002 0000 f03f 1040 0001 0411 1101 0020 .....?.@....... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C9830.rom.txt@2966 PS1, Line 2966: 0000b950: 013a c900 4115 0541 0801 02c4 0041 5420 .:..A..A.....AT trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C9830.rom.txt@3199 PS1, Line 3199: 0000c7e0: 001a 010d e5b3 1b10 5ca2 b31b ef40 5420 ............@T trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C9830.rom.txt@3329 PS1, Line 3329: 0000d000: 0046 4ce5 4110 497f 0404 a500 4a3b 0520 .FL.A.I.....J;. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C9830.rom.txt@3365 PS1, Line 3365: 0000d240: 0001 b400 0000 dc00 0000 dd00 0001 9120 ............... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt File pci1002,990b.rom.txt:

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@13 PS1, Line 13: 000000c0: 2f20 2020 2020 2020 2020 2020 2020 2020 / trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@14 PS1, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@15 PS1, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@23 PS1, Line 23: 00000160: 3636 2e31 0032 3532 3735 3620 2000 2020 66.1.252756 . trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@29 PS1, Line 29: 000001c0: 0000 0003 7900 1f0f 0080 0000 414d 4420 ....y.......AMD trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@434 PS1, Line 434: 00001b10: 2224 70c0 e804 8ae8 e85b ff59 5f5d c320 "$p......[.Y_]. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@638 PS1, Line 638: 000027d0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@713 PS1, Line 713: 00002c80: ca40 8d9c 5803 e840 11a8 0274 0380 ca20 .@..X..@...t... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@907 PS1, Line 907: 000038a0: 0a66 83e8 20e8 effd 6689 4404 c744 0820 .f.. ...f.D..D. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@930 PS1, Line 930: 00003a10: 10eb 0480 4c28 20f6 4534 0175 05c7 4420 ....L( .E4.u..D trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@945 PS1, Line 945: 00003b00: 0175 0333 ffc3 5653 33ff e86c fb8b 5c20 .u.3..VS3..l..\ trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@1359 PS1, Line 1359: 000054e0: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@1514 PS1, Line 1514: 00005e90: 268a 6737 b540 6633 c0eb 0666 b820 0720 &.g7.@f3...f. . trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@1607 PS1, Line 1607: 00006460: 282c 0c11 252a 141e 3236 0f13 272c 1b20 (,..%*..26..',. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@2230 PS1, Line 2230: 00008b50: f3a5 13c9 f3a4 8aca 2bf1 2bf9 81c6 0020 ........+.+.... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@2254 PS1, Line 2254: 00008cd0: 80d2 ecc3 e8f0 fcec c3e8 f8ff b2c0 b020 ............... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@2515 PS1, Line 2515: 00009d20: c580 7401 468b cbf3 a483 fb20 7407 b920 ..t.F...... t.. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@3339 PS1, Line 3339: 0000d0a0: ffff ff08 2000 0024 3088 8303 0406 0020 .... ..$0...... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@3474 PS1, Line 3474: 0000d910: ffff ff1e 2100 001e 2200 0320 2100 2620 ....!...".. !.& trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@3522 PS1, Line 3522: 0000dc10: 3418 0251 0154 0034 1854 003b 185b 7a20 4..Q.T.4.T.;.[z trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@3723 PS1, Line 3723: 0000e8a0: 0f62 4041 3703 0001 0a05 2040 0d25 0820 .b@A7..... @.%. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@3819 PS1, Line 3819: 0000eea0: 0840 1540 1540 1540 1509 2020 2020 2020 .@.@.@.@.. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990b.rom.txt@3825 PS1, Line 3825: 0000ef00: 0008 4015 4015 4015 4015 0920 2020 2020 ..@.@.@.@.. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt File pci1002,990c.rom.txt:

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@13 PS1, Line 13: 000000c0: 2f20 2020 2020 2020 2020 2020 2020 2020 / trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@14 PS1, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@15 PS1, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@23 PS1, Line 23: 00000160: 3636 2e31 0032 3532 3735 3620 2000 2020 66.1.252756 . trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@29 PS1, Line 29: 000001c0: 0000 0003 7900 1f0f 0080 0000 414d 4420 ....y.......AMD trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@434 PS1, Line 434: 00001b10: 2224 70c0 e804 8ae8 e85b ff59 5f5d c320 "$p......[.Y_]. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@638 PS1, Line 638: 000027d0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@713 PS1, Line 713: 00002c80: ca40 8d9c 5803 e840 11a8 0274 0380 ca20 .@..X..@...t... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@907 PS1, Line 907: 000038a0: 0a66 83e8 20e8 effd 6689 4404 c744 0820 .f.. ...f.D..D. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@930 PS1, Line 930: 00003a10: 10eb 0480 4c28 20f6 4534 0175 05c7 4420 ....L( .E4.u..D trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@945 PS1, Line 945: 00003b00: 0175 0333 ffc3 5653 33ff e86c fb8b 5c20 .u.3..VS3..l..\ trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@1359 PS1, Line 1359: 000054e0: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@1514 PS1, Line 1514: 00005e90: 268a 6737 b540 6633 c0eb 0666 b820 0720 &.g7.@f3...f. . trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@1607 PS1, Line 1607: 00006460: 282c 0c11 252a 141e 3236 0f13 272c 1b20 (,..%*..26..',. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@2230 PS1, Line 2230: 00008b50: f3a5 13c9 f3a4 8aca 2bf1 2bf9 81c6 0020 ........+.+.... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@2254 PS1, Line 2254: 00008cd0: 80d2 ecc3 e8f0 fcec c3e8 f8ff b2c0 b020 ............... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@2515 PS1, Line 2515: 00009d20: c580 7401 468b cbf3 a483 fb20 7407 b920 ..t.F...... t.. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@3339 PS1, Line 3339: 0000d0a0: ffff ff08 2000 0024 3088 8303 0406 0020 .... ..$0...... trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@3474 PS1, Line 3474: 0000d910: ffff ff1e 2100 001e 2200 0320 2100 2620 ....!...".. !.& trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@3522 PS1, Line 3522: 0000dc10: 3418 0251 0154 0034 1854 003b 185b 7a20 4..Q.T.4.T.;.[z trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@3723 PS1, Line 3723: 0000e8a0: 0f62 4041 3703 0001 0a05 2040 0d25 0820 .b@A7..... @.%. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@3819 PS1, Line 3819: 0000eea0: 0840 1540 1540 1540 1509 2020 2020 2020 .@.@.@.@.. trailing whitespace

https://review.coreboot.org/#/c/33886/1/pci1002%2C990c.rom.txt@3825 PS1, Line 3825: 0000ef00: 0008 4015 4015 4015 4015 0920 2020 2020 ..@.@.@.@.. trailing whitespace

-- To view, visit https://review.coreboot.org/c/coreboot/+/33886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I717128b279bfaa5164fe6ac7dbfdb64e2984b550 Gerrit-Change-Number: 33886 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 29 Jun 2019 16:13:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

20 Oct 20 Oct

10:47 a.m.

New subject: Change in coreboot[master]: G505S AtomBIOS ROMs: known good binaries with a script to check their...

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33886 )

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

Patch Set 2:

(92 comments)

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6663.rom.txt File pci1002,6663.rom.txt:

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6663.rom.txt@10 PS2, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a500 00c6 cc20 .>x...X@,...... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6663.rom.txt@19 PS2, Line 19: 00000120: 6368 6c61 6e64 2020 2020 2020 2020 2020 chland trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6663.rom.txt@20 PS2, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6663.rom.txt@332 PS2, Line 332: 000014b0: 2366 25ff ff00 0066 3bc8 7321 32db eb20 #f%....f;.s!2.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6663.rom.txt@372 PS2, Line 372: 00001730: 8acd b502 e801 1db1 028d 9c48 01e8 b520 ...........H... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6663.rom.txt@418 PS2, Line 418: 00001a10: 1e24 70c0 e804 8ae8 e85b ff59 5f5d c320 .$p......[.Y_]. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6663.rom.txt@457 PS2, Line 457: 00001c80: 0ac0 7526 8d9c 4c01 66b8 c409 0000 e820 ..u&..L.f...... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6663.rom.txt@621 PS2, Line 621: 000026c0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6663.rom.txt@872 PS2, Line 872: 00003670: 015e c332 c0c3 6650 532e 8b1e 1602 b220 .^.2..fPS...... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6663.rom.txt@1271 PS2, Line 1271: 00004f60: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6663.rom.txt@1544 PS2, Line 1544: 00006070: ff00 0002 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6663.rom.txt@1549 PS2, Line 1549: 000060c0: 0300 0000 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6663.rom.txt@1571 PS2, Line 1571: 00006220: 910a 0820 0000 0392 0a09 2600 0103 0420 ... ......&.... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6663.rom.txt@1658 PS2, Line 1658: 00006790: 8c04 0100 cdd0 3010 0000 0000 0821 4420 ......0......!D trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6663.rom.txt@1686 PS2, Line 1686: 00006950: 141e 0640 2080 00c0 0000 0000 0d0d 2020 ...@ ......... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6663.rom.txt@1729 PS2, Line 1729: 00006c00: 4080 1020 9d03 4000 1020 b603 4080 0020 @.. ..@.. ..@.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6663.rom.txt@2010 PS2, Line 2010: 00007d90: ffff ff00 2105 410a 0000 0056 0041 0320 ....!.A....V.A. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6663.rom.txt@2094 PS2, Line 2094: 000082d0: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6665.rom.txt File pci1002,6665.rom.txt:

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6665.rom.txt@10 PS2, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a501 00c6 cc20 .>x...X@,...... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6665.rom.txt@19 PS2, Line 19: 00000120: 6e64 2020 2020 2020 2020 2020 2020 2020 nd trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6665.rom.txt@20 PS2, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6665.rom.txt@36 PS2, Line 36: 00000230: 0000 8003 4000 290f 0080 0000 414d 4420 ....@.).....AMD trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6665.rom.txt@542 PS2, Line 542: 000021d0: b822 06e8 eeff c3b8 3f06 e8e7 ffc3 b820 ."......?...... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6665.rom.txt@756 PS2, Line 756: 00002f30: fa15 7507 b501 bb18 00eb 0b80 fa14 7520 ..u...........u trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6665.rom.txt@1487 PS2, Line 1487: 00005ce0: 0000 0000 00c3 0100 0000 0006 3075 0020 ............0u. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6665.rom.txt@1659 PS2, Line 1659: 000067a0: 4000 1020 b603 4080 0020 cf03 4000 0020 @.. ..@.. ..@.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6665.rom.txt@1702 PS2, Line 1702: 00006a50: 0324 4114 0015 0541 0601 0a0a 1541 0320 .$A....A.....A. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6665.rom.txt@1726 PS2, Line 1726: 00006bd0: 5044 0828 0040 3071 0920 0800 0075 0920 PD.(.@0q. ...u. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6665.rom.txt@1780 PS2, Line 1780: 00006f30: 1f49 0e00 0725 eb09 fe01 252b 0801 5420 .I...%....%+..T trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6665.rom.txt@1823 PS2, Line 1823: 000071e0: 0125 f705 015b 7a28 0025 0000 0049 2020 .%...[z(.%...I trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C6665.rom.txt@2025 PS2, Line 2025: 00007e80: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C9830.rom.txt File pci1002,9830.rom.txt:

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C9830.rom.txt@13 PS2, Line 13: 000000c0: 6572 6963 2056 4249 4f53 2020 2020 2020 eric VBIOS trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C9830.rom.txt@14 PS2, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C9830.rom.txt@15 PS2, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C9830.rom.txt@125 PS2, Line 125: 000007c0: 0a2c 46fe c975 f48a c559 c302 0104 0820 .,F..u...Y..... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C9830.rom.txt@229 PS2, Line 229: 00000e40: c3bb 0600 e87d 248a c880 e110 d0e9 a820 .....}$........ trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C9830.rom.txt@292 PS2, Line 292: 00001230: 741b e8fb 04e8 1b20 7408 8b56 04e8 1320 t...... t..V... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C9830.rom.txt@773 PS2, Line 773: 00003040: 7d32 c080 ee21 80fa 1e74 15b0 0280 fa20 }2...!...t..... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C9830.rom.txt@1010 PS2, Line 1010: 00003f10: fe8c d08e c026 8b7c 268a 4501 32e4 b920 .....&.|&.E.2.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C9830.rom.txt@1483 PS2, Line 1483: 00005ca0: 1f53 66bb 401c 001c e8f0 c4be 001c b020 .Sf.@.......... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C9830.rom.txt@2270 PS2, Line 2270: 00008dd0: c32e 8e1e 1503 890e 6004 8ac5 2460 a820 ........`...$`. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C9830.rom.txt@2918 PS2, Line 2918: 0000b650: 0002 0000 f03f 1040 0001 0411 1101 0020 .....?.@....... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C9830.rom.txt@2966 PS2, Line 2966: 0000b950: 013a c900 4115 0541 0801 02c4 0041 5420 .:..A..A.....AT trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C9830.rom.txt@3199 PS2, Line 3199: 0000c7e0: 001a 010d e5b3 1b10 5ca2 b31b ef40 5420 ............@T trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C9830.rom.txt@3329 PS2, Line 3329: 0000d000: 0046 4ce5 4110 497f 0404 a500 4a3b 0520 .FL.A.I.....J;. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C9830.rom.txt@3365 PS2, Line 3365: 0000d240: 0001 b400 0000 dc00 0000 dd00 0001 9120 ............... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt File pci1002,990b.rom.txt:

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@13 PS2, Line 13: 000000c0: 2f20 2020 2020 2020 2020 2020 2020 2020 / trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@14 PS2, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@15 PS2, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@23 PS2, Line 23: 00000160: 3636 2e31 0032 3532 3735 3620 2000 2020 66.1.252756 . trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@29 PS2, Line 29: 000001c0: 0000 0003 7900 1f0f 0080 0000 414d 4420 ....y.......AMD trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@434 PS2, Line 434: 00001b10: 2224 70c0 e804 8ae8 e85b ff59 5f5d c320 "$p......[.Y_]. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@638 PS2, Line 638: 000027d0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@713 PS2, Line 713: 00002c80: ca40 8d9c 5803 e840 11a8 0274 0380 ca20 .@..X..@...t... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@907 PS2, Line 907: 000038a0: 0a66 83e8 20e8 effd 6689 4404 c744 0820 .f.. ...f.D..D. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@930 PS2, Line 930: 00003a10: 10eb 0480 4c28 20f6 4534 0175 05c7 4420 ....L( .E4.u..D trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@945 PS2, Line 945: 00003b00: 0175 0333 ffc3 5653 33ff e86c fb8b 5c20 .u.3..VS3..l..\ trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@1359 PS2, Line 1359: 000054e0: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@1514 PS2, Line 1514: 00005e90: 268a 6737 b540 6633 c0eb 0666 b820 0720 &.g7.@f3...f. . trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@1607 PS2, Line 1607: 00006460: 282c 0c11 252a 141e 3236 0f13 272c 1b20 (,..%*..26..',. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@2230 PS2, Line 2230: 00008b50: f3a5 13c9 f3a4 8aca 2bf1 2bf9 81c6 0020 ........+.+.... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@2254 PS2, Line 2254: 00008cd0: 80d2 ecc3 e8f0 fcec c3e8 f8ff b2c0 b020 ............... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@2515 PS2, Line 2515: 00009d20: c580 7401 468b cbf3 a483 fb20 7407 b920 ..t.F...... t.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@3339 PS2, Line 3339: 0000d0a0: ffff ff08 2000 0024 3088 8303 0406 0020 .... ..$0...... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@3474 PS2, Line 3474: 0000d910: ffff ff1e 2100 001e 2200 0320 2100 2620 ....!...".. !.& trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@3522 PS2, Line 3522: 0000dc10: 3418 0251 0154 0034 1854 003b 185b 7a20 4..Q.T.4.T.;.[z trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@3723 PS2, Line 3723: 0000e8a0: 0f62 4041 3703 0001 0a05 2040 0d25 0820 .b@A7..... @.%. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@3819 PS2, Line 3819: 0000eea0: 0840 1540 1540 1540 1509 2020 2020 2020 .@.@.@.@.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990b.rom.txt@3825 PS2, Line 3825: 0000ef00: 0008 4015 4015 4015 4015 0920 2020 2020 ..@.@.@.@.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt File pci1002,990c.rom.txt:

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@13 PS2, Line 13: 000000c0: 2f20 2020 2020 2020 2020 2020 2020 2020 / trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@14 PS2, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@15 PS2, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@23 PS2, Line 23: 00000160: 3636 2e31 0032 3532 3735 3620 2000 2020 66.1.252756 . trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@29 PS2, Line 29: 000001c0: 0000 0003 7900 1f0f 0080 0000 414d 4420 ....y.......AMD trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@434 PS2, Line 434: 00001b10: 2224 70c0 e804 8ae8 e85b ff59 5f5d c320 "$p......[.Y_]. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@638 PS2, Line 638: 000027d0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@713 PS2, Line 713: 00002c80: ca40 8d9c 5803 e840 11a8 0274 0380 ca20 .@..X..@...t... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@907 PS2, Line 907: 000038a0: 0a66 83e8 20e8 effd 6689 4404 c744 0820 .f.. ...f.D..D. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@930 PS2, Line 930: 00003a10: 10eb 0480 4c28 20f6 4534 0175 05c7 4420 ....L( .E4.u..D trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@945 PS2, Line 945: 00003b00: 0175 0333 ffc3 5653 33ff e86c fb8b 5c20 .u.3..VS3..l..\ trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@1359 PS2, Line 1359: 000054e0: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@1514 PS2, Line 1514: 00005e90: 268a 6737 b540 6633 c0eb 0666 b820 0720 &.g7.@f3...f. . trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@1607 PS2, Line 1607: 00006460: 282c 0c11 252a 141e 3236 0f13 272c 1b20 (,..%*..26..',. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@2230 PS2, Line 2230: 00008b50: f3a5 13c9 f3a4 8aca 2bf1 2bf9 81c6 0020 ........+.+.... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@2254 PS2, Line 2254: 00008cd0: 80d2 ecc3 e8f0 fcec c3e8 f8ff b2c0 b020 ............... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@2515 PS2, Line 2515: 00009d20: c580 7401 468b cbf3 a483 fb20 7407 b920 ..t.F...... t.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@3339 PS2, Line 3339: 0000d0a0: ffff ff08 2000 0024 3088 8303 0406 0020 .... ..$0...... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@3474 PS2, Line 3474: 0000d910: ffff ff1e 2100 001e 2200 0320 2100 2620 ....!...".. !.& trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@3522 PS2, Line 3522: 0000dc10: 3418 0251 0154 0034 1854 003b 185b 7a20 4..Q.T.4.T.;.[z trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@3723 PS2, Line 3723: 0000e8a0: 0f62 4041 3703 0001 0a05 2040 0d25 0820 .b@A7..... @.%. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@3819 PS2, Line 3819: 0000eea0: 0840 1540 1540 1540 1509 2020 2020 2020 .@.@.@.@.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/2/pci1002%2C990c.rom.txt@3825 PS2, Line 3825: 0000ef00: 0008 4015 4015 4015 4015 0920 2020 2020 ..@.@.@.@.. trailing whitespace

-- To view, visit https://review.coreboot.org/c/coreboot/+/33886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I717128b279bfaa5164fe6ac7dbfdb64e2984b550 Gerrit-Change-Number: 33886 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 20 Oct 2019 08:47:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

19 Aug 19 Aug

4:35 p.m.

New subject: Change in coreboot[master]: G505S AtomBIOS ROMs: known good binaries with a script to check their...

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33886 )

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

Patch Set 3:

(92 comments)

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6663.rom.txt File pci1002,6663.rom.txt:

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6663.rom.txt@10 PS3, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a500 00c6 cc20 .>x...X@,...... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6663.rom.txt@19 PS3, Line 19: 00000120: 6368 6c61 6e64 2020 2020 2020 2020 2020 chland trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6663.rom.txt@20 PS3, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6663.rom.txt@332 PS3, Line 332: 000014b0: 2366 25ff ff00 0066 3bc8 7321 32db eb20 #f%....f;.s!2.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6663.rom.txt@372 PS3, Line 372: 00001730: 8acd b502 e801 1db1 028d 9c48 01e8 b520 ...........H... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6663.rom.txt@418 PS3, Line 418: 00001a10: 1e24 70c0 e804 8ae8 e85b ff59 5f5d c320 .$p......[.Y_]. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6663.rom.txt@457 PS3, Line 457: 00001c80: 0ac0 7526 8d9c 4c01 66b8 c409 0000 e820 ..u&..L.f...... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6663.rom.txt@621 PS3, Line 621: 000026c0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6663.rom.txt@872 PS3, Line 872: 00003670: 015e c332 c0c3 6650 532e 8b1e 1602 b220 .^.2..fPS...... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6663.rom.txt@1271 PS3, Line 1271: 00004f60: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6663.rom.txt@1544 PS3, Line 1544: 00006070: ff00 0002 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6663.rom.txt@1549 PS3, Line 1549: 000060c0: 0300 0000 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6663.rom.txt@1571 PS3, Line 1571: 00006220: 910a 0820 0000 0392 0a09 2600 0103 0420 ... ......&.... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6663.rom.txt@1658 PS3, Line 1658: 00006790: 8c04 0100 cdd0 3010 0000 0000 0821 4420 ......0......!D trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6663.rom.txt@1686 PS3, Line 1686: 00006950: 141e 0640 2080 00c0 0000 0000 0d0d 2020 ...@ ......... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6663.rom.txt@1729 PS3, Line 1729: 00006c00: 4080 1020 9d03 4000 1020 b603 4080 0020 @.. ..@.. ..@.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6663.rom.txt@2010 PS3, Line 2010: 00007d90: ffff ff00 2105 410a 0000 0056 0041 0320 ....!.A....V.A. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6663.rom.txt@2094 PS3, Line 2094: 000082d0: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6665.rom.txt File pci1002,6665.rom.txt:

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6665.rom.txt@10 PS3, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a501 00c6 cc20 .>x...X@,...... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6665.rom.txt@19 PS3, Line 19: 00000120: 6e64 2020 2020 2020 2020 2020 2020 2020 nd trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6665.rom.txt@20 PS3, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6665.rom.txt@36 PS3, Line 36: 00000230: 0000 8003 4000 290f 0080 0000 414d 4420 ....@.).....AMD trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6665.rom.txt@542 PS3, Line 542: 000021d0: b822 06e8 eeff c3b8 3f06 e8e7 ffc3 b820 ."......?...... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6665.rom.txt@756 PS3, Line 756: 00002f30: fa15 7507 b501 bb18 00eb 0b80 fa14 7520 ..u...........u trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6665.rom.txt@1487 PS3, Line 1487: 00005ce0: 0000 0000 00c3 0100 0000 0006 3075 0020 ............0u. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6665.rom.txt@1659 PS3, Line 1659: 000067a0: 4000 1020 b603 4080 0020 cf03 4000 0020 @.. ..@.. ..@.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6665.rom.txt@1702 PS3, Line 1702: 00006a50: 0324 4114 0015 0541 0601 0a0a 1541 0320 .$A....A.....A. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6665.rom.txt@1726 PS3, Line 1726: 00006bd0: 5044 0828 0040 3071 0920 0800 0075 0920 PD.(.@0q. ...u. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6665.rom.txt@1780 PS3, Line 1780: 00006f30: 1f49 0e00 0725 eb09 fe01 252b 0801 5420 .I...%....%+..T trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6665.rom.txt@1823 PS3, Line 1823: 000071e0: 0125 f705 015b 7a28 0025 0000 0049 2020 .%...[z(.%...I trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C6665.rom.txt@2025 PS3, Line 2025: 00007e80: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C9830.rom.txt File pci1002,9830.rom.txt:

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C9830.rom.txt@13 PS3, Line 13: 000000c0: 6572 6963 2056 4249 4f53 2020 2020 2020 eric VBIOS trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C9830.rom.txt@14 PS3, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C9830.rom.txt@15 PS3, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C9830.rom.txt@125 PS3, Line 125: 000007c0: 0a2c 46fe c975 f48a c559 c302 0104 0820 .,F..u...Y..... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C9830.rom.txt@229 PS3, Line 229: 00000e40: c3bb 0600 e87d 248a c880 e110 d0e9 a820 .....}$........ trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C9830.rom.txt@292 PS3, Line 292: 00001230: 741b e8fb 04e8 1b20 7408 8b56 04e8 1320 t...... t..V... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C9830.rom.txt@773 PS3, Line 773: 00003040: 7d32 c080 ee21 80fa 1e74 15b0 0280 fa20 }2...!...t..... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C9830.rom.txt@1010 PS3, Line 1010: 00003f10: fe8c d08e c026 8b7c 268a 4501 32e4 b920 .....&.|&.E.2.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C9830.rom.txt@1483 PS3, Line 1483: 00005ca0: 1f53 66bb 401c 001c e8f0 c4be 001c b020 .Sf.@.......... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C9830.rom.txt@2270 PS3, Line 2270: 00008dd0: c32e 8e1e 1503 890e 6004 8ac5 2460 a820 ........`...$`. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C9830.rom.txt@2918 PS3, Line 2918: 0000b650: 0002 0000 f03f 1040 0001 0411 1101 0020 .....?.@....... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C9830.rom.txt@2966 PS3, Line 2966: 0000b950: 013a c900 4115 0541 0801 02c4 0041 5420 .:..A..A.....AT trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C9830.rom.txt@3199 PS3, Line 3199: 0000c7e0: 001a 010d e5b3 1b10 5ca2 b31b ef40 5420 ............@T trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C9830.rom.txt@3329 PS3, Line 3329: 0000d000: 0046 4ce5 4110 497f 0404 a500 4a3b 0520 .FL.A.I.....J;. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C9830.rom.txt@3365 PS3, Line 3365: 0000d240: 0001 b400 0000 dc00 0000 dd00 0001 9120 ............... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt File pci1002,990b.rom.txt:

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@13 PS3, Line 13: 000000c0: 2f20 2020 2020 2020 2020 2020 2020 2020 / trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@14 PS3, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@15 PS3, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@23 PS3, Line 23: 00000160: 3636 2e31 0032 3532 3735 3620 2000 2020 66.1.252756 . trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@29 PS3, Line 29: 000001c0: 0000 0003 7900 1f0f 0080 0000 414d 4420 ....y.......AMD trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@434 PS3, Line 434: 00001b10: 2224 70c0 e804 8ae8 e85b ff59 5f5d c320 "$p......[.Y_]. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@638 PS3, Line 638: 000027d0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@713 PS3, Line 713: 00002c80: ca40 8d9c 5803 e840 11a8 0274 0380 ca20 .@..X..@...t... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@907 PS3, Line 907: 000038a0: 0a66 83e8 20e8 effd 6689 4404 c744 0820 .f.. ...f.D..D. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@930 PS3, Line 930: 00003a10: 10eb 0480 4c28 20f6 4534 0175 05c7 4420 ....L( .E4.u..D trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@945 PS3, Line 945: 00003b00: 0175 0333 ffc3 5653 33ff e86c fb8b 5c20 .u.3..VS3..l..\ trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@1359 PS3, Line 1359: 000054e0: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@1514 PS3, Line 1514: 00005e90: 268a 6737 b540 6633 c0eb 0666 b820 0720 &.g7.@f3...f. . trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@1607 PS3, Line 1607: 00006460: 282c 0c11 252a 141e 3236 0f13 272c 1b20 (,..%*..26..',. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@2230 PS3, Line 2230: 00008b50: f3a5 13c9 f3a4 8aca 2bf1 2bf9 81c6 0020 ........+.+.... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@2254 PS3, Line 2254: 00008cd0: 80d2 ecc3 e8f0 fcec c3e8 f8ff b2c0 b020 ............... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@2515 PS3, Line 2515: 00009d20: c580 7401 468b cbf3 a483 fb20 7407 b920 ..t.F...... t.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@3339 PS3, Line 3339: 0000d0a0: ffff ff08 2000 0024 3088 8303 0406 0020 .... ..$0...... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@3474 PS3, Line 3474: 0000d910: ffff ff1e 2100 001e 2200 0320 2100 2620 ....!...".. !.& trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@3522 PS3, Line 3522: 0000dc10: 3418 0251 0154 0034 1854 003b 185b 7a20 4..Q.T.4.T.;.[z trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@3723 PS3, Line 3723: 0000e8a0: 0f62 4041 3703 0001 0a05 2040 0d25 0820 .b@A7..... @.%. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@3819 PS3, Line 3819: 0000eea0: 0840 1540 1540 1540 1509 2020 2020 2020 .@.@.@.@.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990b.rom.txt@3825 PS3, Line 3825: 0000ef00: 0008 4015 4015 4015 4015 0920 2020 2020 ..@.@.@.@.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt File pci1002,990c.rom.txt:

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@13 PS3, Line 13: 000000c0: 2f20 2020 2020 2020 2020 2020 2020 2020 / trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@14 PS3, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@15 PS3, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@23 PS3, Line 23: 00000160: 3636 2e31 0032 3532 3735 3620 2000 2020 66.1.252756 . trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@29 PS3, Line 29: 000001c0: 0000 0003 7900 1f0f 0080 0000 414d 4420 ....y.......AMD trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@434 PS3, Line 434: 00001b10: 2224 70c0 e804 8ae8 e85b ff59 5f5d c320 "$p......[.Y_]. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@638 PS3, Line 638: 000027d0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@713 PS3, Line 713: 00002c80: ca40 8d9c 5803 e840 11a8 0274 0380 ca20 .@..X..@...t... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@907 PS3, Line 907: 000038a0: 0a66 83e8 20e8 effd 6689 4404 c744 0820 .f.. ...f.D..D. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@930 PS3, Line 930: 00003a10: 10eb 0480 4c28 20f6 4534 0175 05c7 4420 ....L( .E4.u..D trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@945 PS3, Line 945: 00003b00: 0175 0333 ffc3 5653 33ff e86c fb8b 5c20 .u.3..VS3..l..\ trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@1359 PS3, Line 1359: 000054e0: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@1514 PS3, Line 1514: 00005e90: 268a 6737 b540 6633 c0eb 0666 b820 0720 &.g7.@f3...f. . trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@1607 PS3, Line 1607: 00006460: 282c 0c11 252a 141e 3236 0f13 272c 1b20 (,..%*..26..',. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@2230 PS3, Line 2230: 00008b50: f3a5 13c9 f3a4 8aca 2bf1 2bf9 81c6 0020 ........+.+.... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@2254 PS3, Line 2254: 00008cd0: 80d2 ecc3 e8f0 fcec c3e8 f8ff b2c0 b020 ............... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@2515 PS3, Line 2515: 00009d20: c580 7401 468b cbf3 a483 fb20 7407 b920 ..t.F...... t.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@3339 PS3, Line 3339: 0000d0a0: ffff ff08 2000 0024 3088 8303 0406 0020 .... ..$0...... trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@3474 PS3, Line 3474: 0000d910: ffff ff1e 2100 001e 2200 0320 2100 2620 ....!...".. !.& trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@3522 PS3, Line 3522: 0000dc10: 3418 0251 0154 0034 1854 003b 185b 7a20 4..Q.T.4.T.;.[z trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@3723 PS3, Line 3723: 0000e8a0: 0f62 4041 3703 0001 0a05 2040 0d25 0820 .b@A7..... @.%. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@3819 PS3, Line 3819: 0000eea0: 0840 1540 1540 1540 1509 2020 2020 2020 .@.@.@.@.. trailing whitespace

https://review.coreboot.org/c/coreboot/+/33886/3/pci1002%2C990c.rom.txt@3825 PS3, Line 3825: 0000ef00: 0008 4015 4015 4015 4015 0920 2020 2020 ..@.@.@.@.. trailing whitespace

-- To view, visit https://review.coreboot.org/c/coreboot/+/33886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I717128b279bfaa5164fe6ac7dbfdb64e2984b550 Gerrit-Change-Number: 33886 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 19 Aug 2020 14:35:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mike Banon (Code Review)

20 Aug 20 Aug

7:13 p.m.

New subject: Change in coreboot[master]: G505S AtomBIOS ROMs: known good binaries with a script to check their...

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33886

to look at the new patch set (#4).

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256

AtomBIOS ROMs are required to enable the integrated and discrete VGA adapters, however to add the discrete GPU support you will also need to apply this change: https://review.coreboot.org/c/coreboot/+/39873 = CB:38200 + CB:38202 + CB:38203 G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches

Here are the SHA256 checksums for these AtomBIOS ROMs:

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/33886/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/33886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I717128b279bfaa5164fe6ac7dbfdb64e2984b550 Gerrit-Change-Number: 33886 Gerrit-PatchSet: 4 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

29 Oct 29 Oct

11:40 a.m.

New subject: Change in coreboot[master]: G505S AtomBIOS ROMs: known good binaries with a script to check their...

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33886 )

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

Patch Set 5:

(92 comments)

File pci1002,6663.rom.txt:

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/0240897c_e76a46a0 PS5, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a500 00c6 cc20 .>x...X@,...... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/3bb1a9dd_8f1f03d8 PS5, Line 19: 00000120: 6368 6c61 6e64 2020 2020 2020 2020 2020 chland trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/095c37e0_e1da50fb PS5, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/a41f89dc_eb45043f PS5, Line 332: 000014b0: 2366 25ff ff00 0066 3bc8 7321 32db eb20 #f%....f;.s!2.. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/ea014cb2_10f63952 PS5, Line 372: 00001730: 8acd b502 e801 1db1 028d 9c48 01e8 b520 ...........H... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/3573a0dc_a1de4323 PS5, Line 418: 00001a10: 1e24 70c0 e804 8ae8 e85b ff59 5f5d c320 .$p......[.Y_]. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/1e9f4df9_91df84aa PS5, Line 457: 00001c80: 0ac0 7526 8d9c 4c01 66b8 c409 0000 e820 ..u&..L.f...... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/c53ddcc9_28c3e963 PS5, Line 621: 000026c0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/4bd5b304_1c4afbb1 PS5, Line 872: 00003670: 015e c332 c0c3 6650 532e 8b1e 1602 b220 .^.2..fPS...... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/a69d2040_d0787db3 PS5, Line 1271: 00004f60: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/96652bf7_d0cd1bce PS5, Line 1544: 00006070: ff00 0002 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/0df74765_1d54caeb PS5, Line 1549: 000060c0: 0300 0000 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/54efe5e3_a2ab44fb PS5, Line 1571: 00006220: 910a 0820 0000 0392 0a09 2600 0103 0420 ... ......&.... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/01179699_a39a1d23 PS5, Line 1658: 00006790: 8c04 0100 cdd0 3010 0000 0000 0821 4420 ......0......!D trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/d1c7a0a9_f5853371 PS5, Line 1686: 00006950: 141e 0640 2080 00c0 0000 0000 0d0d 2020 ...@ ......... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/7ed9e2c8_852b5a06 PS5, Line 1729: 00006c00: 4080 1020 9d03 4000 1020 b603 4080 0020 @.. ..@.. ..@.. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/3d81cd97_82738c1f PS5, Line 2010: 00007d90: ffff ff00 2105 410a 0000 0056 0041 0320 ....!.A....V.A. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/f18483ba_1420faf9 PS5, Line 2094: 000082d0: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace

File pci1002,6665.rom.txt:

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/d7f70c70_c2f37053 PS5, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a501 00c6 cc20 .>x...X@,...... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/6e9c9f8d_36d778b5 PS5, Line 19: 00000120: 6e64 2020 2020 2020 2020 2020 2020 2020 nd trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/b6a9217f_3e32eb3b PS5, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/0a783bba_bef4015d PS5, Line 36: 00000230: 0000 8003 4000 290f 0080 0000 414d 4420 ....@.).....AMD trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/6629239a_f07507af PS5, Line 542: 000021d0: b822 06e8 eeff c3b8 3f06 e8e7 ffc3 b820 ."......?...... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/777fe2b0_82d8c661 PS5, Line 756: 00002f30: fa15 7507 b501 bb18 00eb 0b80 fa14 7520 ..u...........u trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/5446c128_af47134a PS5, Line 1487: 00005ce0: 0000 0000 00c3 0100 0000 0006 3075 0020 ............0u. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/1ad97af5_d17dd76f PS5, Line 1659: 000067a0: 4000 1020 b603 4080 0020 cf03 4000 0020 @.. ..@.. ..@.. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/281ac992_2d5b7d26 PS5, Line 1702: 00006a50: 0324 4114 0015 0541 0601 0a0a 1541 0320 .$A....A.....A. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/a1e08626_9bf47ebb PS5, Line 1726: 00006bd0: 5044 0828 0040 3071 0920 0800 0075 0920 PD.(.@0q. ...u. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/e2730e90_c64edb5b PS5, Line 1780: 00006f30: 1f49 0e00 0725 eb09 fe01 252b 0801 5420 .I...%....%+..T trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/f2455b98_d74260b4 PS5, Line 1823: 000071e0: 0125 f705 015b 7a28 0025 0000 0049 2020 .%...[z(.%...I trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/f1b6525a_c45dce09 PS5, Line 2025: 00007e80: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace

File pci1002,9830.rom.txt:

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/0dca1ec3_22a3e827 PS5, Line 13: 000000c0: 6572 6963 2056 4249 4f53 2020 2020 2020 eric VBIOS trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/06c9dc63_309bb5a7 PS5, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/6b078289_5b3ef744 PS5, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/00d8bbee_15e70375 PS5, Line 125: 000007c0: 0a2c 46fe c975 f48a c559 c302 0104 0820 .,F..u...Y..... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/e04db33e_5a715450 PS5, Line 229: 00000e40: c3bb 0600 e87d 248a c880 e110 d0e9 a820 .....}$........ trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/3124f3ed_9df76ad7 PS5, Line 292: 00001230: 741b e8fb 04e8 1b20 7408 8b56 04e8 1320 t...... t..V... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/c5eb281c_3b0d6055 PS5, Line 773: 00003040: 7d32 c080 ee21 80fa 1e74 15b0 0280 fa20 }2...!...t..... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/f6c83ab5_8ffb4b61 PS5, Line 1010: 00003f10: fe8c d08e c026 8b7c 268a 4501 32e4 b920 .....&.|&.E.2.. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/3a9ed02a_2755ce72 PS5, Line 1483: 00005ca0: 1f53 66bb 401c 001c e8f0 c4be 001c b020 .Sf.@.......... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/367c1c47_1e00915c PS5, Line 2270: 00008dd0: c32e 8e1e 1503 890e 6004 8ac5 2460 a820 ........`...$`. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/b803af10_4972079d PS5, Line 2918: 0000b650: 0002 0000 f03f 1040 0001 0411 1101 0020 .....?.@....... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/695a448c_159cd516 PS5, Line 2966: 0000b950: 013a c900 4115 0541 0801 02c4 0041 5420 .:..A..A.....AT trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/396efc0a_c8925542 PS5, Line 3199: 0000c7e0: 001a 010d e5b3 1b10 5ca2 b31b ef40 5420 ............@T trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/83ac3008_078278c4 PS5, Line 3329: 0000d000: 0046 4ce5 4110 497f 0404 a500 4a3b 0520 .FL.A.I.....J;. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/c4af4dcd_675f13ce PS5, Line 3365: 0000d240: 0001 b400 0000 dc00 0000 dd00 0001 9120 ............... trailing whitespace

File pci1002,990b.rom.txt:

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/0c32440c_5ddd0d61 PS5, Line 13: 000000c0: 2f20 2020 2020 2020 2020 2020 2020 2020 / trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/d12f8ff3_0c67d2c7 PS5, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/8a5be559_12a840be PS5, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/3733d87f_8f7a5962 PS5, Line 23: 00000160: 3636 2e31 0032 3532 3735 3620 2000 2020 66.1.252756 . trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/aa98d959_ac409e29 PS5, Line 29: 000001c0: 0000 0003 7900 1f0f 0080 0000 414d 4420 ....y.......AMD trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/81f988d8_1fb461cb PS5, Line 434: 00001b10: 2224 70c0 e804 8ae8 e85b ff59 5f5d c320 "$p......[.Y_]. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/c9f5b5cc_f25defec PS5, Line 638: 000027d0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/f6114931_eaa1daa1 PS5, Line 713: 00002c80: ca40 8d9c 5803 e840 11a8 0274 0380 ca20 .@..X..@...t... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/be7875d2_067fcaa8 PS5, Line 907: 000038a0: 0a66 83e8 20e8 effd 6689 4404 c744 0820 .f.. ...f.D..D. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/816be6a0_c4898c88 PS5, Line 930: 00003a10: 10eb 0480 4c28 20f6 4534 0175 05c7 4420 ....L( .E4.u..D trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/b3c06e55_f551ce91 PS5, Line 945: 00003b00: 0175 0333 ffc3 5653 33ff e86c fb8b 5c20 .u.3..VS3..l..\ trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/734bc948_4f3671b6 PS5, Line 1359: 000054e0: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/8f5ea402_0c296dc5 PS5, Line 1514: 00005e90: 268a 6737 b540 6633 c0eb 0666 b820 0720 &.g7.@f3...f. . trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/75293973_44e7deec PS5, Line 1607: 00006460: 282c 0c11 252a 141e 3236 0f13 272c 1b20 (,..%*..26..',. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/d6142a62_637c3305 PS5, Line 2230: 00008b50: f3a5 13c9 f3a4 8aca 2bf1 2bf9 81c6 0020 ........+.+.... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/51880728_0b2a0be0 PS5, Line 2254: 00008cd0: 80d2 ecc3 e8f0 fcec c3e8 f8ff b2c0 b020 ............... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/13540dcd_d64bad9e PS5, Line 2515: 00009d20: c580 7401 468b cbf3 a483 fb20 7407 b920 ..t.F...... t.. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/358ad60c_3f98de1b PS5, Line 3339: 0000d0a0: ffff ff08 2000 0024 3088 8303 0406 0020 .... ..$0...... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/c10c5318_3ef484f3 PS5, Line 3474: 0000d910: ffff ff1e 2100 001e 2200 0320 2100 2620 ....!...".. !.& trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/89311b47_32d9c2e6 PS5, Line 3522: 0000dc10: 3418 0251 0154 0034 1854 003b 185b 7a20 4..Q.T.4.T.;.[z trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/a6bac210_1e176de9 PS5, Line 3723: 0000e8a0: 0f62 4041 3703 0001 0a05 2040 0d25 0820 .b@A7..... @.%. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/47804787_e9edd3c2 PS5, Line 3819: 0000eea0: 0840 1540 1540 1540 1509 2020 2020 2020 .@.@.@.@.. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/7ba0d93b_c5afa194 PS5, Line 3825: 0000ef00: 0008 4015 4015 4015 4015 0920 2020 2020 ..@.@.@.@.. trailing whitespace

File pci1002,990c.rom.txt:

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/7aad583e_fdcbd640 PS5, Line 13: 000000c0: 2f20 2020 2020 2020 2020 2020 2020 2020 / trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/f8c862fc_7542af0b PS5, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/e4527c4c_d71d8a42 PS5, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/d5f3ae0f_39b0f71a PS5, Line 23: 00000160: 3636 2e31 0032 3532 3735 3620 2000 2020 66.1.252756 . trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/c53ea0cf_db5321f2 PS5, Line 29: 000001c0: 0000 0003 7900 1f0f 0080 0000 414d 4420 ....y.......AMD trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/dbfda0db_5e2558c8 PS5, Line 434: 00001b10: 2224 70c0 e804 8ae8 e85b ff59 5f5d c320 "$p......[.Y_]. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/d9ef9648_fcc11ff3 PS5, Line 638: 000027d0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/c083ed72_192fa449 PS5, Line 713: 00002c80: ca40 8d9c 5803 e840 11a8 0274 0380 ca20 .@..X..@...t... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/69746c28_2da9b171 PS5, Line 907: 000038a0: 0a66 83e8 20e8 effd 6689 4404 c744 0820 .f.. ...f.D..D. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/7aab6721_3de29cb9 PS5, Line 930: 00003a10: 10eb 0480 4c28 20f6 4534 0175 05c7 4420 ....L( .E4.u..D trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/3e41505b_2fed1d20 PS5, Line 945: 00003b00: 0175 0333 ffc3 5653 33ff e86c fb8b 5c20 .u.3..VS3..l..\ trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/b715ad02_2ef65666 PS5, Line 1359: 000054e0: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/b1cbcc56_fc9b85fc PS5, Line 1514: 00005e90: 268a 6737 b540 6633 c0eb 0666 b820 0720 &.g7.@f3...f. . trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/7697588e_8866a7ca PS5, Line 1607: 00006460: 282c 0c11 252a 141e 3236 0f13 272c 1b20 (,..%*..26..',. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/f3345898_64c6d375 PS5, Line 2230: 00008b50: f3a5 13c9 f3a4 8aca 2bf1 2bf9 81c6 0020 ........+.+.... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/4b2775c0_18ddda46 PS5, Line 2254: 00008cd0: 80d2 ecc3 e8f0 fcec c3e8 f8ff b2c0 b020 ............... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/a0a1ad0f_2b25d0a4 PS5, Line 2515: 00009d20: c580 7401 468b cbf3 a483 fb20 7407 b920 ..t.F...... t.. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/3324a6fa_f7034ed9 PS5, Line 3339: 0000d0a0: ffff ff08 2000 0024 3088 8303 0406 0020 .... ..$0...... trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/20555e31_c11f1681 PS5, Line 3474: 0000d910: ffff ff1e 2100 001e 2200 0320 2100 2620 ....!...".. !.& trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/45a6b4db_e3428e87 PS5, Line 3522: 0000dc10: 3418 0251 0154 0034 1854 003b 185b 7a20 4..Q.T.4.T.;.[z trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/f5a8e8b3_b3197689 PS5, Line 3723: 0000e8a0: 0f62 4041 3703 0001 0a05 2040 0d25 0820 .b@A7..... @.%. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/7dad0ebb_a42e7df7 PS5, Line 3819: 0000eea0: 0840 1540 1540 1540 1509 2020 2020 2020 .@.@.@.@.. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131787): https://review.coreboot.org/c/coreboot/+/33886/comment/5ff0b224_dde61371 PS5, Line 3825: 0000ef00: 0008 4015 4015 4015 4015 0920 2020 2020 ..@.@.@.@.. trailing whitespace

-- To view, visit https://review.coreboot.org/c/coreboot/+/33886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I717128b279bfaa5164fe6ac7dbfdb64e2984b550 Gerrit-Change-Number: 33886 Gerrit-PatchSet: 5 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Comment-Date: Fri, 29 Oct 2021 09:40:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mike Banon (Code Review)

11:51 a.m.

New subject: Change in coreboot[master]: G505S AtomBIOS ROMs: known good binaries with a script to check their...

Attention is currently required from: Mike Banon. Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33886 )

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

Patch Set 5:

(1 comment)

Patchset:

PS5: This change is old, to avoid it potentially being deprecated/removed for its age - I will reupload.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I717128b279bfaa5164fe6ac7dbfdb64e2984b550 Gerrit-Change-Number: 33886 Gerrit-PatchSet: 5 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Mike Banon mikebdp2@gmail.com Gerrit-Comment-Date: Fri, 29 Oct 2021 09:51:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mike Banon (Code Review)

12:14 p.m.

New subject: Change in coreboot[master]: G505S AtomBIOS ROMs: known good binaries with a script to check their...

Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33886 )

Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................

Abandoned

Re-uploaded as CB:58748 with only a minor update of commit message.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I717128b279bfaa5164fe6ac7dbfdb64e2984b550 Gerrit-Change-Number: 33886 Gerrit-PatchSet: 5 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

908

days inactive

1761

days old

coreboot-gerrit@coreboot.org

7 comments

2 participants

tags (0)

participants (2)

build bot (Jenkins) (Code Review)
Mike Banon (Code Review)