Change in ...coreboot[master]: mb/google/hatch: Add EC trigger events and acpi configs - coreboot-gerrit

21 Dec 2018


      Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30281 )
Change subject: mb/google/hatch: Add EC trigger events and acpi configs
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/... 
File src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h:
https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/... 
PS7, Line 79: * __BASEBOARD_EC_H
...
i'm okay, even i'm okay to add tablet related flag if this is 2-in 1 design
Ok, I have updated the commit message to include details on ACPI devices added. Will confirm on the TBMC requirement and update.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a86f609c269cb59e546fc7ba4ba032e5ea8341a
Gerrit-Change-Number: 30281
Gerrit-PatchSet: 12
Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 21 Dec 2018 12:08:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com
Comment-In-Reply-To: Aamir Bohra aamir.bohra@intel.com
Gerrit-MessageType: comment