[M] Change in coreboot[master]: cbmem_top: Change the return value to uintptr_t

[Jakub Czapiga (Code Review)]

Attention is currently required from: Raul Rangel, Jeff Daly, Jonathan Zhang, Matt DeVillier, Julius Werner, Angel Pons, Arthur Heymans, Andrey Petrov, Lance Zhao, Jason Glenesk, Johnny Lin, Tim Wawrzynczak, Christian Walter, Vanessa Eusebio, Fred Reitberger, Elyes Haouas, Tim Chu, Felix Held.

Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69163 )

Change subject: cbmem_top: Change the return value to uintptr_t
......................................................................

Patch Set 7:

(7 comments)

Patchset:

PS7: 
I do not see what this patch aims to achieve. Casts are removed from platform code, but are introduced in common (src/lib/) code. CB:69078 makes sense to me, but this patch not so much.

File src/drivers/mrc_cache/mrc_cache.c:

https://review.coreboot.org/c/coreboot/+/69163/comment/899ae2b6_457ecd0b 
PS5, Line 663: (void *)cbmem_entry_start(to_be_updated) +
Misaligned code

File src/include/imd.h:

https://review.coreboot.org/c/coreboot/+/69163/comment/b6707dbc_73514df2 
PS7, Line 112: uintptr_t imd_entry_at(const struct imd *imd, const struct imd_entry *entry);
It should not be changed as it returns `pointer`. `uintptr_t` is not appropriate here.

File src/lib/imd.c:

https://review.coreboot.org/c/coreboot/+/69163/comment/99ca385b_32f980a1 
PS7, Line 14: uintptr_t relative_pointer(void *base, ssize_t offset)
I think it should remain `void *`. This function has `pointer` in it's name.

https://review.coreboot.org/c/coreboot/+/69163/comment/5c6f3c97_08b81734 
PS7, Line 267: relative_pointer(imdr_root(imdr), e->start_offset);
`(uintptr_t)` will be needed here after reverting above.

https://review.coreboot.org/c/coreboot/+/69163/comment/89657e34_7e32b7a6 
PS7, Line 568: uintptr_t imd_entry_at(const struct imd *imd, const struct imd_entry *entry)
As in header file

File src/lib/imd_cbmem.c:

https://review.coreboot.org/c/coreboot/+/69163/comment/6ef7b49f_e5268d81 
PS7, Line 143: uintptr_t cbmem_add(u32 id, u64 size)
This also should remain `void *`