Attention is currently required from: Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52635 )
Change subject: Added Star Labs labtop series ......................................................................
Patch Set 1:
(161 comments)
File src/ec/starlabs/it8987/acpi/cmos.asl:
https://review.coreboot.org/c/coreboot/+/52635/comment/9aeaa301_70756857 PS1, Line 6: NVRI, 8, trailing whitespace
File src/ec/starlabs/it8987/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/52635/comment/ce69ed46_adde8971 PS1, Line 33: // Our embedded controller device. trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/51ca8ab9_5633e5c6 PS1, Line 46: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/2dc6044d_e76f7f1c PS1, Line 49: Name(PVOL, ASL_PVOL_DEFOF_NUM) trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/47d2cf76_94280fce PS1, Line 52: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/78060df4_7cb95c12 PS1, Line 82: Name(BTEN, 0) trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/93b579b3_d1ab2cef PS1, Line 111: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/88486884_993c6351 PS1, Line 113: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/6bf6ce1a_dfc96493 PS1, Line 120: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/9b9a1e2c_615cc8fd PS1, Line 123: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/be36b8c1_4beba9f7 PS1, Line 134: } trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/858270a4_09a06a2c PS1, Line 157: Offset(0x06), trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/b06f55cb_95898b26 PS1, Line 158: SKID, 8, // SKU ID trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/39aa9fc2_ae928cc6 PS1, Line 162: ECOS, 8, // Enter OS flag trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/2dd42b4d_ad26a4d1 PS1, Line 164: ECHK, 8, // Hot keys flag trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/61354733_b1ea0705 PS1, Line 169: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/0c0224d5_0bf4ca76 PS1, Line 174: Offset(0x1E), trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/4728b85d_64fa1c10 PS1, Line 175: BTHP, 8, // Health Battery Percentage trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/f8fa7dbb_c46d39ad PS1, Line 181: Offset(0x2C), trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/e78df3cc_4afd69ab PS1, Line 182: FNST, 8, // FN LOCK key status. trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/c609226b_15502565 PS1, Line 184: Offset(0x3F), trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/ffa14f9e_f7fd7578 PS1, Line 185: SFAN, 8, // Set Fan Speed. trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/d2d9462d_e43ad863 PS1, Line 186: BTMP, 16, // Battery Temperature. trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/50f3ad79_25f799cb PS1, Line 187: BCNT, 16, // Battery Cycle Count. trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/d17fa8ff_22718d4e PS1, Line 188: FRMP, 16, // Fan Current Speed. trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/cc3639be_c09b2caa PS1, Line 189: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/582dd3b1_a705f3ba PS1, Line 217: CPTM, 8, // CPU Temperature trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/ce8e8acc_9171852a PS1, Line 219: Offset(0x72), trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/bd1917a5_592ebb56 PS1, Line 220: TER2, 8, // Charger Temperature, Charger thermistor support trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/f03c7ee1_b17e22f3 PS1, Line 226: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/47116e95_a53b86bb PS1, Line 236: B1CR, 16, // Battery#1 Present Rate trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/8b9a685e_3d0a84b5 PS1, Line 240: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/cbcbdce5_905c06e2 PS1, Line 255: MGIC, 8, trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/196a2115_067778a8 PS1, Line 261: MGO0, 8, trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/0feb0341_a9d1cf56 PS1, Line 276: MGOF, 8, trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/038de469_974ad01e PS1, Line 284: // PPM->OPM CCI indicator trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/65102ce4_e15cead4 PS1, Line 299: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/52eae7a5_3c7e7435 PS1, Line 305: , 1, // BIT7 Reserved trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/92ac8568_91d04bcd PS1, Line 353: Method(_Q40) trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/bdc5907a_4ca63d4c PS1, Line 357: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/2b1ebe8d_1dcecb31 PS1, Line 358: Method(_Q41) trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/2920dcbc_74fa762b PS1, Line 362: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/20fd54d5_1c3bfe26 PS1, Line 363: Method(_Q42) trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/cc2e5031_55211321 PS1, Line 367: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/ae330b10_e7500bbd PS1, Line 368: Method(_Q43) trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/995c2603_75c88f2c PS1, Line 373: Method(_Q44) trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/3ebbd170_89fbeef5 PS1, Line 376: } trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/9ce09474_4533a1ea PS1, Line 378: Method(_Q45) trailing whitespace
File src/ec/starlabs/it8987/acpi/hid.asl:
https://review.coreboot.org/c/coreboot/+/52635/comment/e07182e2_6f2d9d25 PS1, Line 32: 0x11111111, trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/84b8ed0a_559a0024 PS1, Line 33: 0x22222222, trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/73bd7071_029df4e9 PS1, Line 34: 0x33333333, trailing whitespace
File src/ec/starlabs/it8987/acpi/keyboard.asl:
https://review.coreboot.org/c/coreboot/+/52635/comment/8bd31beb_65a6d544 PS1, Line 10: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/9d614b40_6450c435 PS1, Line 17: } trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/6f9fd807_f1f9b5d2 PS1, Line 18: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/1c6e6810_332e9080 PS1, Line 22: _SB.HIDD.HPEM(8) trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/4c0edbd7_b66c5e20 PS1, Line 25: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/9a1c88a3_fa258530 PS1, Line 29: } trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/5e9afd0c_01587d10 PS1, Line 30: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/f5f985fc_c2e24a36 PS1, Line 34: } trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/65efca66_4b64523f PS1, Line 50: trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/6d893241_8056a355 PS1, Line 57: trailing whitespace
File src/ec/starlabs/it8987/acpi/lid.asl:
https://review.coreboot.org/c/coreboot/+/52635/comment/35ed190c_ccc353ea PS1, Line 35: DEBUG = "---> IT8987 LID: Q0C (close event)" trailing whitespace
File src/mainboard/starlabs/labtop/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/52635/comment/7c2eaa0e_497445d5 PS1, Line 35: "PRP00001", trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/9a5f317a_fed2b90c PS1, Line 46: /* trailing whitespace
File src/mainboard/starlabs/labtop/ramstage.c:
https://review.coreboot.org/c/coreboot/+/52635/comment/2d094f06_fa906b0b PS1, Line 10: void mainboard_silicon_init_params(FSPS_UPD *supd) need consistent spacing around '*' (ctx:WxV)
File src/mainboard/starlabs/labtop/variants/cml/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/52635/comment/9294c91e_09b3a919 PS1, Line 18: _PAD_CFG_STRUCT(GPP_E22, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/dd7d03d9_e412884a PS1, Line 19: _PAD_CFG_STRUCT(GPP_E23, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/8805a728_c79c2a6c PS1, Line 22: _PAD_CFG_STRUCT(GPP_H6, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/ead8a5d0_970d2667 PS1, Line 23: _PAD_CFG_STRUCT(GPP_H7, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/4ee0e261_dc88c146 PS1, Line 35: _PAD_CFG_STRUCT(GPP_A0, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/0b2f0515_e722b9ea PS1, Line 36: _PAD_CFG_STRUCT(GPP_A1, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NATIVE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/931c6a72_19fbf8e5 PS1, Line 37: _PAD_CFG_STRUCT(GPP_A2, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NATIVE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/e69f36a6_cb2dab08 PS1, Line 38: _PAD_CFG_STRUCT(GPP_A3, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NATIVE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/4eb756bb_c6b65026 PS1, Line 39: _PAD_CFG_STRUCT(GPP_A4, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NATIVE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/95b2adb8_34e60418 PS1, Line 40: _PAD_CFG_STRUCT(GPP_A5, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/62596edb_e30f6296 PS1, Line 41: _PAD_CFG_STRUCT(GPP_A6, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/a7c03867_81909a14 PS1, Line 42: _PAD_CFG_STRUCT(GPP_A7, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(LEVEL) | PAD_BUF(TX_DISABLE) | PAD_IRQ_ROUTE(IOAPIC), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/8a004c60_0eee1567 PS1, Line 43: _PAD_CFG_STRUCT(GPP_A8, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/4eccc71e_26e1f689 PS1, Line 44: _PAD_CFG_STRUCT(GPP_A9, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/0c48ae74_2dfc274f PS1, Line 45: _PAD_CFG_STRUCT(GPP_A10, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/e269fa51_e217faea PS1, Line 46: _PAD_CFG_STRUCT(GPP_A13, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/b8dbeb6b_b2117b33 PS1, Line 47: _PAD_CFG_STRUCT(GPP_A14, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/c974e68b_4449733d PS1, Line 48: _PAD_CFG_STRUCT(GPP_A15, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/e7ba9d8e_90bc8c42 PS1, Line 49: _PAD_CFG_STRUCT(GPP_A16, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/bc651c83_d6498939 PS1, Line 50: _PAD_CFG_STRUCT(GPP_A18, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/fa836d74_7776796c PS1, Line 51: _PAD_CFG_STRUCT(GPP_A19, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/2a8b027c_3983e737 PS1, Line 52: _PAD_CFG_STRUCT(GPP_A20, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/b3374c38_2a8a3b43 PS1, Line 53: _PAD_CFG_STRUCT(GPP_A21, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/c6140c57_2df5fe96 PS1, Line 54: _PAD_CFG_STRUCT(GPP_A22, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/3d0cbaae_11323356 PS1, Line 55: _PAD_CFG_STRUCT(GPP_A23, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/617f4e1a_91e60351 PS1, Line 58: _PAD_CFG_STRUCT(GPP_B2, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/6a99c4ec_8e08b9c1 PS1, Line 59: _PAD_CFG_STRUCT(GPP_B3, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(LEVEL) | PAD_IRQ_ROUTE(IOAPIC) | PAD_BUF(TX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/a0d5f1a8_de297c36 PS1, Line 60: _PAD_CFG_STRUCT(GPP_B4, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/e156c8b0_52c699c1 PS1, Line 61: _PAD_CFG_STRUCT(GPP_B11, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/3274f682_d4f8218d PS1, Line 62: _PAD_CFG_STRUCT(GPP_B12, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), trailing whitespace
https://review.coreboot.org/c/coreboot/+/52635/comment/6168dbae_570172e9 PS1, Line 62: _PAD_CFG_STRUCT(GPP_B12, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/a0e3fecf_796ac80d PS1, Line 63: _PAD_CFG_STRUCT(GPP_B13, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/31f51a69_76dd6203 PS1, Line 64: _PAD_CFG_STRUCT(GPP_B14, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/a1836b31_a088daea PS1, Line 65: _PAD_CFG_STRUCT(GPP_B15, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/afe6e389_5deca948 PS1, Line 66: _PAD_CFG_STRUCT(GPP_B16, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(LEVEL) | PAD_IRQ_ROUTE(IOAPIC) | PAD_BUF(TX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/58a4c727_f8b9f9da PS1, Line 67: _PAD_CFG_STRUCT(GPP_B17, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/b66257a0_072d5394 PS1, Line 68: _PAD_CFG_STRUCT(GPP_B23, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/ab5a66b6_81eefc86 PS1, Line 71: _PAD_CFG_STRUCT(GPP_G5, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/b0cf12d2_701bd40a PS1, Line 72: _PAD_CFG_STRUCT(GPP_G7, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/04366306_ce43057b PS1, Line 75: _PAD_CFG_STRUCT(GPP_D9, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/0ec95520_c5ab8f6c PS1, Line 76: _PAD_CFG_STRUCT(GPP_D10, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(LEVEL) | PAD_IRQ_ROUTE(IOAPIC) | PAD_BUF(TX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/3dd01022_84ec4f67 PS1, Line 77: _PAD_CFG_STRUCT(GPP_D11, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(LEVEL) | PAD_IRQ_ROUTE(SCI) | PAD_BUF(TX_DISABLE) | PAD_RX_POL(INVERT), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/f205d6b9_5ec6ac42 PS1, Line 78: _PAD_CFG_STRUCT(GPP_D14, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/801c7b84_2c4efd41 PS1, Line 79: _PAD_CFG_STRUCT(GPP_D15, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/ecc14906_de14a3f0 PS1, Line 80: _PAD_CFG_STRUCT(GPP_D16, PAD_FUNC(GPIO) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/26ead0aa_1934ba16 PS1, Line 81: _PAD_CFG_STRUCT(GPP_D17, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/a64ad0e5_b3087a13 PS1, Line 82: _PAD_CFG_STRUCT(GPP_D18, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/5b1e7ce4_8db7d68b PS1, Line 83: _PAD_CFG_STRUCT(GPP_D19, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/721960a5_7b5a3b4c PS1, Line 84: _PAD_CFG_STRUCT(GPP_D20, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/f1227186_0a19cc44 PS1, Line 87: _PAD_CFG_STRUCT(GPP_F0, PAD_FUNC(GPIO) | PAD_RESET(RSMRST) | PAD_TRIG(LEVEL) | PAD_BUF(TX_RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/4d3c22aa_582b1e0e PS1, Line 88: _PAD_CFG_STRUCT(GPP_F1, PAD_FUNC(GPIO) | PAD_RESET(RSMRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/95c80276_0e7b336b PS1, Line 89: _PAD_CFG_STRUCT(GPP_F2, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/bc18e5de_35a2bcd3 PS1, Line 90: _PAD_CFG_STRUCT(GPP_F3, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/070ab564_e950aecc PS1, Line 91: _PAD_CFG_STRUCT(GPP_F4, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/00de08d8_2e08ca9c PS1, Line 92: _PAD_CFG_STRUCT(GPP_F5, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/6666adec_1e5eaf95 PS1, Line 93: _PAD_CFG_STRUCT(GPP_F6, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/c62f328e_1fd6e91a PS1, Line 94: _PAD_CFG_STRUCT(GPP_F7, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/91e5785a_30f6c7ed PS1, Line 95: _PAD_CFG_STRUCT(GPP_F10, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/5b371055_62a9264f PS1, Line 98: _PAD_CFG_STRUCT(GPP_H0, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/0e9170d1_b997fb32 PS1, Line 99: _PAD_CFG_STRUCT(GPP_H1, PAD_FUNC(NF3) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/0a30c99c_a95219cf PS1, Line 100: _PAD_CFG_STRUCT(GPP_H2, PAD_FUNC(NF3) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/ad165c19_dde68a59 PS1, Line 101: _PAD_CFG_STRUCT(GPP_H3, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/8935d867_9e32adc7 PS1, Line 102: _PAD_CFG_STRUCT(GPP_H4, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/ce9f0408_d8a59b06 PS1, Line 103: _PAD_CFG_STRUCT(GPP_H5, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/f1777678_bcdd4f24 PS1, Line 104: _PAD_CFG_STRUCT(GPP_H10, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/5a36bf92_0ae14ac0 PS1, Line 105: _PAD_CFG_STRUCT(GPP_H11, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/8401abe6_79a7b0db PS1, Line 106: _PAD_CFG_STRUCT(GPP_H12, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/49e9bd7a_b14e982a PS1, Line 107: _PAD_CFG_STRUCT(GPP_H13, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/35f5027d_d3c35dff PS1, Line 108: _PAD_CFG_STRUCT(GPP_H14, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/f41aaa2a_3c55e775 PS1, Line 109: _PAD_CFG_STRUCT(GPP_H15, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/8e91cb71_9e8c7a1c PS1, Line 110: _PAD_CFG_STRUCT(GPP_H16, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/54da2841_385b3562 PS1, Line 111: _PAD_CFG_STRUCT(GPP_H17, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/687842f9_b8f4b64f PS1, Line 112: _PAD_CFG_STRUCT(GPP_H19, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/a607ede6_682a500e PS1, Line 113: _PAD_CFG_STRUCT(GPP_H20, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/d596f608_a0e194f9 PS1, Line 114: _PAD_CFG_STRUCT(GPP_H22, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/3bca0b6d_76ada8e1 PS1, Line 117: _PAD_CFG_STRUCT(GPP_C2, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/87175551_5dcb3e4d PS1, Line 118: _PAD_CFG_STRUCT(GPP_C5, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(LEVEL) | PAD_IRQ_ROUTE(SCI) | PAD_BUF(TX_DISABLE) | PAD_RX_POL(INVERT), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/0864e58a_7b8ddcd7 PS1, Line 119: _PAD_CFG_STRUCT(GPP_C8, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(LEVEL) | PAD_IRQ_ROUTE(IOAPIC) | PAD_BUF(TX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/ccd0eb91_416342f3 PS1, Line 120: _PAD_CFG_STRUCT(GPP_C9, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(EDGE_SINGLE) | PAD_IRQ_ROUTE(SCI) | PAD_BUF(TX_DISABLE) | PAD_RX_POL(INVERT), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/4b7a5f72_f49de871 PS1, Line 121: _PAD_CFG_STRUCT(GPP_C10, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/436c692f_92fd7888 PS1, Line 122: _PAD_CFG_STRUCT(GPP_C11, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(LEVEL) | PAD_IRQ_ROUTE(IOAPIC) | PAD_BUF(TX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/3d4c7803_1439465b PS1, Line 123: _PAD_CFG_STRUCT(GPP_C12, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/5465f0fb_0e63dab8 PS1, Line 124: _PAD_CFG_STRUCT(GPP_C15, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/66f47511_4c7fe582 PS1, Line 125: _PAD_CFG_STRUCT(GPP_C16, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/d9250118_b8dfc47c PS1, Line 126: _PAD_CFG_STRUCT(GPP_C17, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/687816a5_f8c24fb1 PS1, Line 127: _PAD_CFG_STRUCT(GPP_C18, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/b802dfc8_ad65735e PS1, Line 128: _PAD_CFG_STRUCT(GPP_C19, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/79ec460b_4b0fdb21 PS1, Line 131: _PAD_CFG_STRUCT(GPP_E2, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/dcf87a89_227a8342 PS1, Line 132: _PAD_CFG_STRUCT(GPP_E3, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(EDGE_SINGLE) | PAD_IRQ_ROUTE(SMI) | PAD_BUF(TX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/bf751b3d_001c2f81 PS1, Line 133: _PAD_CFG_STRUCT(GPP_E4, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(LEVEL) | PAD_IRQ_ROUTE(SCI) | PAD_BUF(TX_DISABLE) | PAD_RX_POL(INVERT), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/aef29450_58feb0bb PS1, Line 134: _PAD_CFG_STRUCT(GPP_E7, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(EDGE_SINGLE) | PAD_BUF(TX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/9af58816_875b8c10 PS1, Line 135: _PAD_CFG_STRUCT(GPP_E11, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/91438786_baabc43e PS1, Line 136: _PAD_CFG_STRUCT(GPP_E12, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/ce88b2bb_f223ba96 PS1, Line 137: _PAD_CFG_STRUCT(GPP_E15, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_CFG0_TX_STATE, PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/1a480f26_ad3d2617 PS1, Line 138: _PAD_CFG_STRUCT(GPP_E16, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(LEVEL) | PAD_IRQ_ROUTE(SCI) | PAD_BUF(TX_DISABLE) | PAD_RX_POL(INVERT), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/52635/comment/a0329f64_231ee083 PS1, Line 139: _PAD_CFG_STRUCT(GPP_E17, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(NONE)), line over 96 characters
-
build bot (Jenkins) (Code Review)