Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60833 )
Change subject: soc/mediatek/mt8186: fix incorrect devapc settings
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60833/comment/2cec13ec_0b4fb43e
PS3, Line 7: revise
if this is fixing something then it's fix instead of revise. […]
Done
https://review.coreboot.org/c/coreboot/+/60833/comment/896373f3_976c2720
PS3, Line 9: We need to protect debugsys for firmware image without serial console.
: Original settings for protecting debugsys is wrong which will cause some
: hardware modules failed to set their registers correctly.
can you explain why moving it from one function to another is the right fix?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60833
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibce626386ac1f8de42f8717c4ad9ba403640b3ec
Gerrit-Change-Number: 60833
Gerrit-PatchSet: 5
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 06 Jan 2022 08:53:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment