Johnny Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
mb/ocp/deltalake: Add SMM console log level override
The log level is set to a configuration value, since SMI should not take too much time searching flash VPD.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/Makefile.inc M src/mainboard/ocp/deltalake/loglevel_vpd.c 3 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/1
diff --git a/src/mainboard/ocp/deltalake/Kconfig b/src/mainboard/ocp/deltalake/Kconfig index bb907f1..1d00c29 100644 --- a/src/mainboard/ocp/deltalake/Kconfig +++ b/src/mainboard/ocp/deltalake/Kconfig @@ -57,4 +57,9 @@ bool default y
+config SMM_CONSOLE_LOGLEVEL + int + depends on DEBUG_SMI + default 7 + endif # BOARD_OCP_DELTALAKE diff --git a/src/mainboard/ocp/deltalake/Makefile.inc b/src/mainboard/ocp/deltalake/Makefile.inc index e961a34..9718f4c 100644 --- a/src/mainboard/ocp/deltalake/Makefile.inc +++ b/src/mainboard/ocp/deltalake/Makefile.inc @@ -8,5 +8,9 @@ ramstage-y += ramstage.c ipmi.c ramstage-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c all-$(CONFIG_CONSOLE_OVERRIDE_LOGLEVEL) += loglevel_vpd.c +ifeq ($(CONFIG_DEBUG_SMI),y) +smm-$(CONFIG_CONSOLE_OVERRIDE_LOGLEVEL) += loglevel_vpd.c +endif + CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/include CPPFLAGS_common += -I$(CONFIG_FSP_HEADER_PATH) diff --git a/src/mainboard/ocp/deltalake/loglevel_vpd.c b/src/mainboard/ocp/deltalake/loglevel_vpd.c index 3faf37a..21f3652 100644 --- a/src/mainboard/ocp/deltalake/loglevel_vpd.c +++ b/src/mainboard/ocp/deltalake/loglevel_vpd.c @@ -11,6 +11,8 @@ int log_level = COREBOOT_LOG_LEVEL_DEFAULT; char val_str[VPD_LEN];
+ if (ENV_SMM) + return CONFIG_SMM_CONSOLE_LOGLEVEL; if (vpd_gets(COREBOOT_LOG_LEVEL, val_str, VPD_LEN, VPD_RW_THEN_RO)) { log_level = (int)atol(val_str); if (log_level < 0 || log_level >= BIOS_NEVER)
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47006/1/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/Kconfig:
https://review.coreboot.org/c/coreboot/+/47006/1/src/mainboard/ocp/deltalake... PS1, Line 63: default 7 The default should be 7 when DEBUG_SMI is set; and should be 4 when DEBUG_SMI is not set.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
Patch Set 1:
Another more generic option is to pass the console loglevel via relocatable module parameters to the SMM module? That way the logic of fetching the console loglevel is done in the ramstage but passed on to SMM.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Jonathan Zhang, Jingle Hsu, Rocky Phagura, Angel Pons, Arthur Heymans, Morgan Jang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47006
to look at the new patch set (#2).
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
mb/ocp/deltalake: Add SMM console log level override
1. Select DEBUG_SMI so we can see SMM handler logs at run-time. 2. Add VPD variable 'smm_log_level' that can be read and passed to SMM module via module parameter. By default is 0 which disables most of the SMM log.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/Makefile.inc M src/mainboard/ocp/deltalake/loglevel_vpd.c M src/mainboard/ocp/deltalake/vpd.h 4 files changed, 25 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/2
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Patch Set 1:
Another more generic option is to pass the console loglevel via relocatable module parameters to the SMM module? That way the logic of fetching the console loglevel is done in the ramstage but passed on to SMM.
Uploaded CB:49460 for review.
File src/mainboard/ocp/deltalake/Kconfig:
https://review.coreboot.org/c/coreboot/+/47006/comment/51d23e23_1ef10ce5 PS1, Line 63: default 7
The default should be 7 when DEBUG_SMI is set; and should be 4 when DEBUG_SMI is not set.
Default set to 0 and can be changed via VPD 'smm_log_levle', since we don't want to see SMM handler log in the OS.
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/ocp/deltalake/Kconfig:
https://review.coreboot.org/c/coreboot/+/47006/comment/2133e883_f6e9e75a PS2, Line 7: DEBUG_SMI I don't think selecting (force-enabling) a debug option is a good idea. If anything, you can override its default value:
config DEBUG_SMI default y
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang. Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Patrick Georgi, Martin Roth, Jonathan Zhang, Jingle Hsu, Rocky Phagura, Angel Pons, Arthur Heymans, Morgan Jang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47006
to look at the new patch set (#3).
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
mb/ocp/deltalake: Add SMM console log level override
Add VPD variable 'smm_log_level' that can be read and passed to SMM module via module parameter. By default is 0 which disables most of the SMM log.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Makefile.inc M src/mainboard/ocp/deltalake/loglevel_vpd.c M src/mainboard/ocp/deltalake/vpd.h 3 files changed, 24 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/3
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Angel Pons. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/ocp/deltalake/Kconfig:
https://review.coreboot.org/c/coreboot/+/47006/comment/fb5a7687_1f8fa59f PS2, Line 7: DEBUG_SMI
I don't think selecting (force-enabling) a debug option is a good idea. […]
Done
Attention is currently required from: Anjaneya "Reddy" Chagam, Johnny Lin, Angel Pons. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/ocp/deltalake/vpd.h:
https://review.coreboot.org/c/coreboot/+/47006/comment/d763ecb1_4ec541a7 PS3, Line 36: /* SMM log level */ What are the possible values? Let's document here. Should we check to make sure the value is legitimate before passing it to SMM?
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Angel Pons. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/ocp/deltalake/vpd.h:
https://review.coreboot.org/c/coreboot/+/47006/comment/e2ac3d22_3d1aa999 PS3, Line 36: /* SMM log level */
What are the possible values? Let's document here. […]
SMM log levels are the same as coreboot log level, from 0 (BIOS_EMERG) to 8 (BIOS_SPEW). Similar check like coreboot_log_level was done in https://review.coreboot.org/c/coreboot/+/47006/3/src/mainboard/ocp/deltalake...
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/ocp/deltalake/loglevel_vpd.c:
https://review.coreboot.org/c/coreboot/+/47006/comment/0dab655c_5e55688e PS3, Line 26: int log_level = SMM_LOG_LEVEL_DEFAULT; : : if (vpd_get_int(SMM_LOG_LEVEL, VPD_RW_THEN_RO, (int *const) &log_level)) { : if (log_level < 0 || log_level >= BIOS_NEVER) : log_level = SMM_LOG_LEVEL_DEFAULT; : } : return log_level; To avoid duplicating code, I would extract the common stuff into a helper function:
static int get_loglevel_from_vpd(const char *const key, const int fallback) { int log_level = fallback;
if (vpd_get_int(key, VPD_RW_THEN_RO, &log_level)) { if (log_level < 0 || log_level >= BIOS_NEVER) log_level = fallback; } return log_level; }
Attention is currently required from: Anjaneya "Reddy" Chagam, Johnny Lin. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/ocp/deltalake/vpd.h:
https://review.coreboot.org/c/coreboot/+/47006/comment/3236a3c3_715ffc8e PS3, Line 36: /* SMM log level */
SMM log levels are the same as coreboot log level, from 0 (BIOS_EMERG) to 8 (BIOS_SPEW). […]
Ack
Attention is currently required from: Anjaneya "Reddy" Chagam. Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Patrick Georgi, Martin Roth, Jonathan Zhang, Jingle Hsu, Rocky Phagura, Angel Pons, Arthur Heymans, Morgan Jang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47006
to look at the new patch set (#4).
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
mb/ocp/deltalake: Add SMM console log level override
Add VPD variable 'smm_log_level' that can be read and passed to SMM module via module parameter. By default is 0 which disables most of the SMM log.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/Makefile.inc M src/mainboard/ocp/deltalake/loglevel_vpd.c M src/mainboard/ocp/deltalake/vpd.h 4 files changed, 32 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/4
Attention is currently required from: Anjaneya "Reddy" Chagam. Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Patrick Georgi, Martin Roth, Jonathan Zhang, Jingle Hsu, Rocky Phagura, Angel Pons, Arthur Heymans, Morgan Jang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47006
to look at the new patch set (#6).
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
mb/ocp/deltalake: Add SMM console log level override
Add VPD variable 'smm_log_level' that can be read and passed to SMM module. By default is 0 which disables most of the SMM log.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/Makefile.inc M src/mainboard/ocp/deltalake/loglevel_vpd.c M src/mainboard/ocp/deltalake/vpd.h 4 files changed, 32 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/6
Attention is currently required from: Anjaneya "Reddy" Chagam, Angel Pons. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/ocp/deltalake/loglevel_vpd.c:
https://review.coreboot.org/c/coreboot/+/47006/comment/8096e0ec_8efaec4d PS3, Line 26: int log_level = SMM_LOG_LEVEL_DEFAULT; : : if (vpd_get_int(SMM_LOG_LEVEL, VPD_RW_THEN_RO, (int *const) &log_level)) { : if (log_level < 0 || log_level >= BIOS_NEVER) : log_level = SMM_LOG_LEVEL_DEFAULT; : } : return log_level;
To avoid duplicating code, I would extract the common stuff into a helper function: […]
Done
Attention is currently required from: Anjaneya "Reddy" Chagam, Johnny Lin, Angel Pons. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
Patch Set 9:
(2 comments)
File src/mainboard/ocp/deltalake/Kconfig:
https://review.coreboot.org/c/coreboot/+/47006/comment/a8bdee88_21d9056d PS9, Line 68: default y I am sort of against having this enabled by default, since this adds the entire console and uart driver to SMM. You could still add it under configs/ for build-testing and production (with care).
Is this change done in co-operation with maintainer Quanta? I am not convinced you really need to adjust SMM loglevel, but if you do, do you really want it done via VPD for production or would a Kconfig for development be enough?
Also, UART should be excluded from OS with DEBUG_SMI=y due the console_init() call, e.g. interrupts will get disabled and baudrate potentially changed. OS may not survive from this.
File src/mainboard/ocp/deltalake/loglevel_vpd.c:
https://review.coreboot.org/c/coreboot/+/47006/comment/d81d2519_edd1d8ce PS9, Line 9: int get_console_loglevel(void) Okay, so with DEBUG_SMI=y console_init() is called once every time SMI is entered. The code in console/init.c does not really expect that, and it currently unconditionally calls get_console_loglevel() every time, while doing it just once would be just fine.
I guess this is what motivated for change CB:49460?
Attention is currently required from: Anjaneya "Reddy" Chagam, Angel Pons, Kyösti Mälkki. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
Patch Set 9:
(2 comments)
File src/mainboard/ocp/deltalake/Kconfig:
https://review.coreboot.org/c/coreboot/+/47006/comment/994f845f_590a2022 PS9, Line 68: default y
I am sort of against having this enabled by default, since this adds the entire console and uart dri […]
The behavior is to align with our UEFI analogous firmware that by default the SMI log is disabled so OS wouldn't see them, but if needed we can enable it for debugging without re-building and re-flashing the firmware. It's easier for testing and debugging with one single image that can enable/disable this at run-time by following a reboot to take effect.
Yes the UART needs to be taken care of when SMI interrupting OS and exiting from execution, Rocky has implemented the patch for that but it's not uploaded yet, so far I think his patch works without problem.
File src/mainboard/ocp/deltalake/loglevel_vpd.c:
https://review.coreboot.org/c/coreboot/+/47006/comment/d2a629ec_4e7fd658 PS9, Line 9: int get_console_loglevel(void)
Okay, so with DEBUG_SMI=y console_init() is called once every time SMI is entered. […]
Yes.
Attention is currently required from: Anjaneya "Reddy" Chagam, Angel Pons, Kyösti Mälkki. Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Patrick Georgi, Martin Roth, Jonathan Zhang, Jingle Hsu, Rocky Phagura, Angel Pons, Arthur Heymans, Morgan Jang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47006
to look at the new patch set (#10).
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
mb/ocp/deltalake: Add SMM console log level override
Add VPD variable 'smm_log_level' that can be read and passed to SMM module. By default is 0 which disables most of the SMM log.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/Makefile.inc M src/mainboard/ocp/deltalake/loglevel_vpd.c M src/mainboard/ocp/deltalake/uartio_vpd.c M src/mainboard/ocp/deltalake/vpd.h 5 files changed, 37 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/10
Attention is currently required from: Anjaneya "Reddy" Chagam, Angel Pons, Kyösti Mälkki. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/ocp/deltalake/uartio_vpd.c:
https://review.coreboot.org/c/coreboot/+/47006/comment/4e4b2e7f_94ffb516 PS10, Line 14: /* Return default vaule in SMM for now. */ 'vaule' may be misspelled - perhaps 'value'?
Attention is currently required from: Anjaneya "Reddy" Chagam, Angel Pons, Kyösti Mälkki. Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Patrick Georgi, Martin Roth, Jonathan Zhang, Jingle Hsu, Rocky Phagura, Angel Pons, Arthur Heymans, Morgan Jang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47006
to look at the new patch set (#11).
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
mb/ocp/deltalake: Add SMM console log level override
Add VPD variable 'smm_log_level' that can be read and passed to SMM module. By default is 0 which disables most of the SMM log.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/Makefile.inc M src/mainboard/ocp/deltalake/loglevel_vpd.c M src/mainboard/ocp/deltalake/uartio_vpd.c M src/mainboard/ocp/deltalake/vpd.h 5 files changed, 37 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/11
Attention is currently required from: Anjaneya "Reddy" Chagam, Angel Pons, Kyösti Mälkki. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Add SMM console log level override ......................................................................
Patch Set 11:
(1 comment)
File src/mainboard/ocp/deltalake/Kconfig:
https://review.coreboot.org/c/coreboot/+/47006/comment/2bdaf29e_6d0fb523 PS9, Line 68: default y
The behavior is to align with our UEFI analogous firmware that by default the SMI log is disabled so […]
Mark resolved first, please feel free to comment.
Attention is currently required from: Anjaneya "Reddy" Chagam, Angel Pons, Kyösti Mälkki. Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Patrick Georgi, Martin Roth, Jonathan Zhang, Jingle Hsu, Rocky Phagura, Angel Pons, Arthur Heymans, Morgan Jang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47006
to look at the new patch set (#12).
Change subject: mb/ocp/deltalake: Override console log level and UART IO port for SMM ......................................................................
mb/ocp/deltalake: Override console log level and UART IO port for SMM
Add VPD variable 'smm_log_level' that can be read and passed to SMM module. By default it's 0 therefore it disables most of the SMM log.
Override mainboard_set_smm_info() that reads VPD variables for SMM log level and UART IO port, and it's set to smm_board_info with bit encoding: bits[5:4]: uart io select, bits[3:0]: console log level.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/Makefile.inc M src/mainboard/ocp/deltalake/loglevel_vpd.c M src/mainboard/ocp/deltalake/ramstage.c M src/mainboard/ocp/deltalake/uartio_vpd.c M src/mainboard/ocp/deltalake/vpd.h 6 files changed, 43 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/12
Attention is currently required from: Anjaneya "Reddy" Chagam, Angel Pons, Kyösti Mälkki. Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Patrick Georgi, Martin Roth, Jonathan Zhang, Jingle Hsu, Rocky Phagura, Angel Pons, Arthur Heymans, Morgan Jang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47006
to look at the new patch set (#13).
Change subject: mb/ocp/deltalake: Override console log level and UART IO port for SMM ......................................................................
mb/ocp/deltalake: Override console log level and UART IO port for SMM
Add VPD variable 'smm_log_level' that can be read and passed to SMM. By default it's 0 therefore it disables most of the SMM log.
Override mainboard_set_smm_info() that reads VPD variables for SMM log level and UART IO port, and it's set to smm_board_info with bit encoding: bits[5:4]: uart io select, bits[3:0]: console log level.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/Makefile.inc M src/mainboard/ocp/deltalake/loglevel_vpd.c M src/mainboard/ocp/deltalake/ramstage.c M src/mainboard/ocp/deltalake/uartio_vpd.c M src/mainboard/ocp/deltalake/vpd.h 6 files changed, 43 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/13
Attention is currently required from: Anjaneya "Reddy" Chagam, Angel Pons, Kyösti Mälkki. Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Patrick Georgi, Martin Roth, Jonathan Zhang, Jingle Hsu, Rocky Phagura, Angel Pons, Arthur Heymans, Morgan Jang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47006
to look at the new patch set (#16).
Change subject: mb/ocp/deltalake: Override console log level and UART IO port for SMM ......................................................................
mb/ocp/deltalake: Override console log level and UART IO port for SMM
Add VPD variable 'smm_log_level' that can be read and passed to SMM. By default it's 0 therefore it disables most of the SMM log.
Override mainboard_set_smm_info() that reads VPD variables for SMM log level and UART IO port, and it's set to smm_board_info with bit encoding: bits[5:4]: uart io select, bits[3:0]: console log level.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/Makefile.inc M src/mainboard/ocp/deltalake/loglevel_vpd.c M src/mainboard/ocp/deltalake/ramstage.c M src/mainboard/ocp/deltalake/uartio_vpd.c M src/mainboard/ocp/deltalake/vpd.h 6 files changed, 43 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/16
Attention is currently required from: Anjaneya "Reddy" Chagam, Angel Pons, Kyösti Mälkki. Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Patrick Georgi, Martin Roth, Jonathan Zhang, Jingle Hsu, Rocky Phagura, Angel Pons, Arthur Heymans, Morgan Jang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47006
to look at the new patch set (#18).
Change subject: mb/ocp/deltalake: Override console log level and UART IO port for SMM ......................................................................
mb/ocp/deltalake: Override console log level and UART IO port for SMM
Add VPD variable 'smm_log_level' that can be read and passed to SMM. By default it's 0 therefore it disables most of the SMM log.
Override mainboard_set_smm_info() that reads VPD variables for SMM log level and UART IO port, and it's set to smm_board_info with bit encoding: bits[5:4]: uart io select, bits[3:0]: console log level.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/Makefile.inc M src/mainboard/ocp/deltalake/loglevel_vpd.c M src/mainboard/ocp/deltalake/ramstage.c M src/mainboard/ocp/deltalake/uartio_vpd.c M src/mainboard/ocp/deltalake/vpd.h 6 files changed, 43 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/18
Attention is currently required from: Anjaneya "Reddy" Chagam, Johnny Lin, Angel Pons, Kyösti Mälkki. Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Override console log level and UART IO port for SMM ......................................................................
Patch Set 19: Code-Review+1
Attention is currently required from: Anjaneya "Reddy" Chagam, Angel Pons, Kyösti Mälkki. Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Patrick Georgi, Martin Roth, Jonathan Zhang, Jingle Hsu, Rocky Phagura, Angel Pons, Arthur Heymans, Morgan Jang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47006
to look at the new patch set (#20).
Change subject: mb/ocp/deltalake: Override SMM console log level and UART IO port via VPD ......................................................................
mb/ocp/deltalake: Override SMM console log level and UART IO port via VPD
Add VPD variable 'smm_log_level' that can be read and passed to SMM. By default it's 0 therefore it disables most of the SMM log. Override mainboard_set_smm_log_level() that reads VPD variables for SMM log level, and override mainboard_set_smm_uart_for_console() for SMM UART IO port.
Select DEBUG_SMI.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/Makefile.inc M src/mainboard/ocp/deltalake/loglevel_vpd.c M src/mainboard/ocp/deltalake/ramstage.c M src/mainboard/ocp/deltalake/uartio_vpd.c M src/mainboard/ocp/deltalake/vpd.h 6 files changed, 44 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/20
Attention is currently required from: Anjaneya "Reddy" Chagam, Johnny Lin, Angel Pons, Kyösti Mälkki. Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Patrick Georgi, Martin Roth, Jonathan Zhang, Jingle Hsu, Rocky Phagura, Angel Pons, Arthur Heymans, Morgan Jang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47006
to look at the new patch set (#22).
Change subject: mb/ocp/deltalake: Override SMM console log level and UART IO port via VPD ......................................................................
mb/ocp/deltalake: Override SMM console log level and UART IO port via VPD
Add VPD variable 'smm_log_level' that can be read and passed to SMM. By default it's 0 therefore it disables most of the SMM log. Override mainboard_set_smm_log_level() that reads VPD variables for SMM log level, and override mainboard_set_smm_uart_for_console() for SMM UART IO port.
Select DEBUG_SMI.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/Makefile.inc M src/mainboard/ocp/deltalake/loglevel_vpd.c M src/mainboard/ocp/deltalake/ramstage.c M src/mainboard/ocp/deltalake/uartio_vpd.c M src/mainboard/ocp/deltalake/vpd.h 6 files changed, 44 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/22
Attention is currently required from: Anjaneya "Reddy" Chagam, Angel Pons, Kyösti Mälkki. Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Patrick Georgi, Martin Roth, Jonathan Zhang, Jingle Hsu, Rocky Phagura, Angel Pons, Arthur Heymans, Morgan Jang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47006
to look at the new patch set (#23).
Change subject: mb/ocp/deltalake: Override SMM console log level via VPD ......................................................................
mb/ocp/deltalake: Override SMM console log level via VPD
Add VPD variable 'smm_log_level' that can be read and passed to SMM. By default it's 0 therefore it disables most of the SMM log. Whe we need to see SMM log we can set this VPD to a larger value to enable it. Override mainboard_set_smm_log_level() that reads VPD variables for SMM log level.
Select DEBUG_SMI.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/Makefile.inc M src/mainboard/ocp/deltalake/loglevel_vpd.c M src/mainboard/ocp/deltalake/ramstage.c M src/mainboard/ocp/deltalake/vpd.h 5 files changed, 34 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/23
Attention is currently required from: Anjaneya "Reddy" Chagam, Christian Walter, Angel Pons, Kyösti Mälkki, Tim Chu.
Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Martin L Roth, Jonathan Zhang, Jingle Hsu, Rocky Phagura, Angel Pons, Arthur Heymans, Morgan Jang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47006
to look at the new patch set (#24).
Change subject: mb/ocp/deltalake: Override SMM console log level via VPD ......................................................................
mb/ocp/deltalake: Override SMM console log level via VPD
Add VPD variable 'smm_log_level' that can be read and passed to SMM. By default it's 0 therefore it disables most of the SMM log. When we need to see SMM log we can set this VPD to a larger value to enable it. Override mainboard_set_smm_log_level() that reads VPD variables for SMM log level.
Select DEBUG_SMI.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/Makefile.inc M src/mainboard/ocp/deltalake/loglevel_vpd.c M src/mainboard/ocp/deltalake/ramstage.c M src/mainboard/ocp/deltalake/vpd.h 5 files changed, 53 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/24
Attention is currently required from: Anjaneya "Reddy" Chagam, Johnny Lin, Christian Walter, Angel Pons, Kyösti Mälkki, Tim Chu.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Override SMM console log level via VPD ......................................................................
Patch Set 24: Code-Review+1
(1 comment)
Patchset:
PS24: Need to rebase
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Christian Walter, Angel Pons, Kyösti Mälkki, Tim Chu.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Override SMM console log level via VPD ......................................................................
Patch Set 24:
(1 comment)
Patchset:
PS24:
Need to rebase
Because it depends on CB:56468
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Christian Walter, Angel Pons, Kyösti Mälkki, Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Override SMM console log level via VPD ......................................................................
Patch Set 24: Code-Review-1
(1 comment)
File src/mainboard/ocp/deltalake/loglevel_vpd.c:
https://review.coreboot.org/c/coreboot/+/47006/comment/a6b2e14d_8ad96fbf PS24, Line 19: int get_console_loglevel(void) It makes no sense to have this at the mainboard level for smm. Move this to common smm code. This also removes the need for the global variable smm_log_level which is also set in common code.
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Christian Walter, Angel Pons, Kyösti Mälkki, Tim Chu.
Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Martin L Roth, Jonathan Zhang, Christian Walter, Jingle Hsu, Rocky Phagura, Angel Pons, Arthur Heymans, Morgan Jang, Tim Chu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47006
to look at the new patch set (#25).
Change subject: mb/ocp/deltalake: Set SMM console log level via VPD ......................................................................
mb/ocp/deltalake: Set SMM console log level via VPD
Add VPD variable 'smm_log_level' that can be read and passed to SMM. By default it's zero therefore it disables most of the SMM log. When we need to see SMM log we can set this VPD to a larger value to enable it. Implement mainboard_set_smm_log_level() that reads VPD variables for SMM log level.
Select DEBUG_SMI.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/loglevel_vpd.c M src/mainboard/ocp/deltalake/ramstage.c M src/mainboard/ocp/deltalake/vpd.h 4 files changed, 44 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/25
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Christian Walter, Angel Pons, Arthur Heymans, Kyösti Mälkki, Tim Chu.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Set SMM console log level via VPD ......................................................................
Patch Set 26:
(1 comment)
File src/mainboard/ocp/deltalake/loglevel_vpd.c:
https://review.coreboot.org/c/coreboot/+/47006/comment/a21c3a43_643fa9f7 PS24, Line 19: int get_console_loglevel(void)
It makes no sense to have this at the mainboard level for smm. Move this to common smm code. […]
Done. Thanks this is much cleaner now.
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Kyösti Mälkki, Tim Chu.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Set SMM console log level via VPD ......................................................................
Patch Set 27: Code-Review+2
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Kyösti Mälkki, Tim Chu.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Set SMM console log level via VPD ......................................................................
Patch Set 27: Code-Review+2
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Kyösti Mälkki, Tim Chu.
Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Martin L Roth, Jonathan Zhang, Christian Walter, Jingle Hsu, Angel Pons, Rocky Phagura, Arthur Heymans, Morgan Jang, Tim Chu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47006
to look at the new patch set (#28).
Change subject: mb/ocp/deltalake: Set SMM console log level via VPD ......................................................................
mb/ocp/deltalake: Set SMM console log level via VPD
Add VPD variable 'smm_log_level' that can be read and passed to SMM. By default it's zero therefore it disables most of the SMM log. When we need to see SMM log we can set this VPD to a larger value to enable it. Implement mainboard_set_smm_log_level() that reads VPD variables for SMM log level.
Select DEBUG_SMI.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/Makefile.inc M src/mainboard/ocp/deltalake/loglevel_vpd.c M src/mainboard/ocp/deltalake/ramstage.c M src/mainboard/ocp/deltalake/vpd.h 5 files changed, 45 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/28
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Kyösti Mälkki, Tim Chu.
Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Martin L Roth, Jonathan Zhang, Christian Walter, Jingle Hsu, Angel Pons, Rocky Phagura, Arthur Heymans, Morgan Jang, Tim Chu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47006
to look at the new patch set (#29).
Change subject: mb/ocp/deltalake: Set SMM console log level via VPD ......................................................................
mb/ocp/deltalake: Set SMM console log level via VPD
Add VPD variable 'smm_log_level' that can be read and passed to SMM. By default it's zero therefore it disables most of the SMM log. When we need to see SMM log we can set this VPD to a larger value to enable it. Implement mainboard_set_smm_log_level() that reads VPD variables for SMM log level.
Select DEBUG_SMI and RUNTIME_CONFIGURABLE_SMM_LOGLEVEL.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/Makefile.inc M src/mainboard/ocp/deltalake/loglevel_vpd.c M src/mainboard/ocp/deltalake/ramstage.c M src/mainboard/ocp/deltalake/vpd.h 5 files changed, 46 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/29
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Kyösti Mälkki, Tim Chu.
Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Martin L Roth, Jonathan Zhang, Christian Walter, Jingle Hsu, Angel Pons, Rocky Phagura, Arthur Heymans, Morgan Jang, Tim Chu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47006
to look at the new patch set (#31).
Change subject: mb/ocp/deltalake: Set SMM console log level via VPD ......................................................................
mb/ocp/deltalake: Set SMM console log level via VPD
Add VPD variable 'smm_log_level' that can be read and passed to SMM. By default it's zero therefore it disables most of the SMM log. When we need to see SMM log we can set this VPD to a larger value to enable it. Implement mainboard_set_smm_log_level() that reads VPD variables for SMM log level.
Select DEBUG_SMI and RUNTIME_CONFIGURABLE_SMM_LOGLEVEL.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/Makefile.inc M src/mainboard/ocp/deltalake/loglevel_vpd.c M src/mainboard/ocp/deltalake/ramstage.c M src/mainboard/ocp/deltalake/vpd.h 5 files changed, 46 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/31
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Kyösti Mälkki, Tim Chu.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Set SMM console log level via VPD ......................................................................
Patch Set 31: Code-Review+2
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Kyösti Mälkki, Tim Chu.
Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Martin L Roth, Jonathan Zhang, David Hendricks, Christian Walter, Jingle Hsu, Angel Pons, Rocky Phagura, Arthur Heymans, Morgan Jang, Tim Chu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47006
to look at the new patch set (#32).
Change subject: mb/ocp/deltalake: Set SMM console log level via VPD ......................................................................
mb/ocp/deltalake: Set SMM console log level via VPD
Select DEBUG_SMI and RUNTIME_CONFIGURABLE_SMM_LOGLEVEL.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/Makefile.inc 2 files changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/47006/32
Attention is currently required from: Anjaneya "Reddy" Chagam, Johnny Lin, Christian Walter, Arthur Heymans, Kyösti Mälkki, Tim Chu.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Set SMM console log level via VPD ......................................................................
Patch Set 32:
(1 comment)
Patchset:
PS32: Johnny, were dependencies merged into the upstream tip?
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Christian Walter, Arthur Heymans, Kyösti Mälkki, Tim Chu.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Set SMM console log level via VPD ......................................................................
Patch Set 33:
(1 comment)
Patchset:
PS32:
Johnny, were dependencies merged into the upstream tip?
they are not as Gerrit shows, Jenkins lint failures are caused by the changes below it. With such a massive change train we need to fix the base changes and push maybe 10 changes at a time..need to figure out a way to fix and push lint failures.
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Kyösti Mälkki, Tim Chu.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Set SMM console log level via VPD ......................................................................
Patch Set 36: Code-Review+2
Attention is currently required from: Anjaneya "Reddy" Chagam, Johnny Lin, David Hendricks, Christian Walter, Arthur Heymans, Kyösti Mälkki, Tim Chu.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Set SMM console log level via VPD ......................................................................
Patch Set 36: Code-Review+2
David Hendricks has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Set SMM console log level via VPD ......................................................................
mb/ocp/deltalake: Set SMM console log level via VPD
Select DEBUG_SMI and RUNTIME_CONFIGURABLE_SMM_LOGLEVEL.
Tested=On OCP Delta Lake, SMM log level can be changed via VPD variable.
Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c Signed-off-by: Johnny Lin johnny_lin@wiwynn.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47006 Reviewed-by: David Hendricks david.hendricks@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jonathan Zhang jonzhang@fb.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/Makefile.inc 2 files changed, 23 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved Jonathan Zhang: Looks good to me, approved
diff --git a/src/mainboard/ocp/deltalake/Kconfig b/src/mainboard/ocp/deltalake/Kconfig index 6abffd4..191d89c 100644 --- a/src/mainboard/ocp/deltalake/Kconfig +++ b/src/mainboard/ocp/deltalake/Kconfig @@ -17,6 +17,7 @@ select MEMORY_MAPPED_TPM select MAINBOARD_HAS_TPM2 select UART_OVERRIDE_BAUDRATE + select RUNTIME_CONFIGURABLE_SMM_LOGLEVEL
config UART_FOR_CONSOLE int @@ -57,4 +58,7 @@ bool default y
+config DEBUG_SMI + default y + endif # BOARD_OCP_DELTALAKE diff --git a/src/mainboard/ocp/deltalake/Makefile.inc b/src/mainboard/ocp/deltalake/Makefile.inc index 1b05344..a6b6d37 100644 --- a/src/mainboard/ocp/deltalake/Makefile.inc +++ b/src/mainboard/ocp/deltalake/Makefile.inc @@ -8,4 +8,5 @@ ramstage-y += ramstage.c ipmi.c ramstage-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c all-y += console.c +smm-y += console.c CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/include
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
build bot (Jenkins) (Code Review)
-
David Hendricks (Code Review)
-
Johnny Lin (Code Review)
-
Jonathan Zhang (Code Review)
-
Kyösti Mälkki (Code Review)
-
Martin L Roth (Code Review)
-
Rocky Phagura (Code Review)