Change in ...coreboot[master]: nb/intel/i945: Don't try to rewrite on SLOTCAP

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

HAOUAS Elyes (Code Review)

22 Jan 2019 22 Jan '19

3:49 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31036

Change subject: nb/intel/i945: Don't try to rewrite on SLOTCAP ......................................................................

nb/intel/i945: Don't try to rewrite on SLOTCAP

SLOTCAP is R/WO, it becomes RO after the first write.

Change-Id: I27579bc634e357490defabb041457aaa010fb1c8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/early_init.c 1 file changed, 0 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/31036/1

diff --git a/src/northbridge/intel/i945/early_init.c b/src/northbridge/intel/i945/early_init.c index 09a18e3..15c3a33 100644 --- a/src/northbridge/intel/i945/early_init.c +++ b/src/northbridge/intel/i945/early_init.c @@ -719,9 +719,6 @@ reg32 = pci_read_config32(PCI_DEV(0, 0x01, 0), 0x328); pci_write_config32(PCI_DEV(0, 0x01, 0), 0x328, reg32);

- reg8 = pci_read_config8(PCI_DEV(0, 0x01, 0), SLOTCAP); - pci_write_config8(PCI_DEV(0, 0x01, 0), SLOTCAP, reg8); - /* Additional PCIe graphics setup */ reg32 = pci_read_config32(PCI_DEV(0, 0x01, 0), 0xf0); reg32 |= (3 << 26);

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

HAOUAS Elyes (Code Review)

22 Jan 22 Jan

3:55 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31036 )

Change subject: nb/intel/i945: Don't try to rewrite on SLOTCAP ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31036/1/src/northbridge/intel/i945/early_ini... File src/northbridge/intel/i945/early_init.c:

https://review.coreboot.org/#/c/31036/1/src/northbridge/intel/i945/early_ini... PS1, Line 594: : : : : : : so don't try to write into this reg on line #723

-- To view, visit https://review.coreboot.org/c/coreboot/+/31036 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27579bc634e357490defabb041457aaa010fb1c8 Gerrit-Change-Number: 31036 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Comment-Date: Tue, 22 Jan 2019 14:55:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

4:06 p.m.

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31036

to look at the new patch set (#2).

Change subject: nb/intel/i945: Don't try to rewrite on SLOTCAP ......................................................................

nb/intel/i945: Don't try to rewrite on SLOTCAP

SLOTCAP is R/WO, it becomes RO after the first write.

Change-Id: I27579bc634e357490defabb041457aaa010fb1c8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/early_init.c 1 file changed, 0 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/31036/2

HAOUAS Elyes (Code Review)

28 Jan 28 Jan

9:14 a.m.

New subject: Change in ...coreboot[master]: nb/intel/i945: Remove 2nd write on SLOTCAP (R/WO)

Hello Kyösti Mälkki, Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31036

to look at the new patch set (#5).

Change subject: nb/intel/i945: Remove 2nd write on SLOTCAP (R/WO) ......................................................................

nb/intel/i945: Remove 2nd write on SLOTCAP (R/WO)

SLOTCAP is R/WO, it becomes RO after the first write. Write already done on line #583.

Change-Id: I27579bc634e357490defabb041457aaa010fb1c8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/early_init.c 1 file changed, 0 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/31036/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/31036 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27579bc634e357490defabb041457aaa010fb1c8 Gerrit-Change-Number: 31036 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

9:15 a.m.

New subject: Change in ...coreboot[master]: nb/intel/i945: Remove 2nd write on SLOTCAP (R/WO)

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31036 )

Change subject: nb/intel/i945: Remove 2nd write on SLOTCAP (R/WO) ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/31036/5/src/northbridge/intel/i945/early_ini... File src/northbridge/intel/i945/early_init.c:

https://review.coreboot.org/#/c/31036/5/src/northbridge/intel/i945/early_ini... PS5, Line 587: : : : : : : so don't try to rewrite on that register - see line #715

-- To view, visit https://review.coreboot.org/c/coreboot/+/31036 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27579bc634e357490defabb041457aaa010fb1c8 Gerrit-Change-Number: 31036 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 28 Jan 2019 08:15:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

1:13 p.m.

New subject: Change in ...coreboot[master]: nb/intel/i945: Remove 2nd write on SLOTCAP (R/WO)

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31036 )

Change subject: nb/intel/i945: Remove 2nd write on SLOTCAP (R/WO) ......................................................................

Patch Set 5: Code-Review+1

Tested how?

-- To view, visit https://review.coreboot.org/c/coreboot/+/31036 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27579bc634e357490defabb041457aaa010fb1c8 Gerrit-Change-Number: 31036 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 28 Jan 2019 12:13:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

1:32 p.m.

New subject: Change in ...coreboot[master]: nb/intel/i945: Remove 2nd write on SLOTCAP (R/WO)

Hello Kyösti Mälkki, Patrick Rudolph, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31036

to look at the new patch set (#6).

Change subject: nb/intel/i945: Remove 2nd write on SLOTCAP (R/WO) ......................................................................

nb/intel/i945: Remove 2nd write on SLOTCAP (R/WO)

SLOTCAP is R/WO, it becomes RO after the first write. Write already done on line #583.

Tested using kprint before and after on 945G-M4 board.

Change-Id: I27579bc634e357490defabb041457aaa010fb1c8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/early_init.c 1 file changed, 0 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/31036/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/31036 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27579bc634e357490defabb041457aaa010fb1c8 Gerrit-Change-Number: 31036 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

28 Feb 28 Feb

2:54 p.m.

New subject: Change in ...coreboot[master]: nb/intel/i945: Remove 2nd write on SLOTCAP (R/WO)

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31036 )

Change subject: nb/intel/i945: Remove 2nd write on SLOTCAP (R/WO) ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31036 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27579bc634e357490defabb041457aaa010fb1c8 Gerrit-Change-Number: 31036 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 28 Feb 2019 13:54:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

18 Mar 18 Mar

10:15 a.m.

New subject: Change in ...coreboot[master]: nb/intel/i945: Remove 2nd write on SLOTCAP (R/WO)

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31036 )

Change subject: nb/intel/i945: Remove 2nd write on SLOTCAP (R/WO) ......................................................................

nb/intel/i945: Remove 2nd write on SLOTCAP (R/WO)

SLOTCAP is R/WO, it becomes RO after the first write. Write already done on line #583.

Tested using kprint before and after on 945G-M4 board.

Change-Id: I27579bc634e357490defabb041457aaa010fb1c8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/31036 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/northbridge/intel/i945/early_init.c 1 file changed, 0 insertions(+), 5 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

diff --git a/src/northbridge/intel/i945/early_init.c b/src/northbridge/intel/i945/early_init.c index 7ab2525..e8cacf6 100644 --- a/src/northbridge/intel/i945/early_init.c +++ b/src/northbridge/intel/i945/early_init.c @@ -552,8 +552,6 @@ u32 reg32; u16 reg16;

- u8 reg8; - printk(BIOS_DEBUG, "Enabling PCI Express x16 Link\n");

reg16 = pci_read_config16(PCI_DEV(0, 0x00, 0), DEVEN); @@ -733,9 +731,6 @@ reg32 = pci_read_config32(PCI_DEV(0, 0x01, 0), 0x328); pci_write_config32(PCI_DEV(0, 0x01, 0), 0x328, reg32);

-- To view, visit https://review.coreboot.org/c/coreboot/+/31036 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27579bc634e357490defabb041457aaa010fb1c8 Gerrit-Change-Number: 31036 Gerrit-PatchSet: 9 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1859

days inactive

1914

days old

coreboot-gerrit@coreboot.org

8 comments

3 participants

tags (0)

participants (3)

HAOUAS Elyes (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)