[M] Change in coreboot[main]: mb/google/fatcat/var/fatcat: Add initial FW_CONFIG

[Cliff Huang (Code Review)]

Attention is currently required from: Subrata Banik.

Cliff Huang has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84543?usp=email )

Change subject: mb/google/fatcat/var/fatcat: Add initial FW_CONFIG
......................................................................

Patch Set 6:

(6 comments)

File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/84543/comment/5f9413ef_fdfdfefc?usp... :
PS6, Line 5: 		option ALC722_SNDW		2
ALC722 is built-in. should we remove AUDIO_NONE and make ALC722_SNDW as default with value '0'?

https://review.coreboot.org/c/coreboot/+/84543/comment/e1406073_f0bdd443?usp... :
PS6, Line 20: 	field TOUCHSCREEN 8 10
Can we drop prefix [field]_ from most of fw_config options? that is,
using LPSS_I2C instead of TOUCHSCREEN_LPSS_I2C, for instance.

with current option naming,  we will have:
if (fw_config_probe(FW_CONFIG(TOUCHSCREEN, TOUCHSCREEN_LPSS_I2C))) { ...

This will reach 96 characters easily with indentation. Also, it would be expanded in marco and resulting the following in static.c:
        .field_name = FW_CONFIG_FIELD_TOUCHSCREEN_NAME,
        .option_name = FW_CONFIG_FIELD_TOUCHSCREEN_OPTION_TOUCHSCREEN_LPSS_I2C_NAME,
        .mask = FW_CONFIG_FIELD_TOUCHSCREEN_MASK,
        .value = FW_CONFIG_FIELD_TOUCHSCREEN_OPTION_TOUCHCREEN_LPSS_I2C_VALUE,

The option name will not be used as marco directly so we are save and won't run into naming conflict.

same thing for the options in other filed with [field]_ as prefix.

https://review.coreboot.org/c/coreboot/+/84543/comment/c824a931_0bd501c3?usp... :
PS6, Line 25: 		option TOUCHSCREEN_THC0_I2C	4
either THC0_SPI in line 24 or THC_I2C for consistency.

https://review.coreboot.org/c/coreboot/+/84543/comment/7a86532f_e81a7172?usp... :
PS6, Line 34: 		option SD_GENSYS		1
so far, only bayhub is tested working one.

https://review.coreboot.org/c/coreboot/+/84543/comment/cc4668b9_dd58bca4?usp... :
PS6, Line 37: 	field STORAGE 15 16
This is okay, but we are not limited to have single storage. For instance, two NVMe at the same time.

https://review.coreboot.org/c/coreboot/+/84543/comment/c26b1b51_67fb7095?usp... :
PS6, Line 55: end
do we need WWAN for fatcat?