Change in coreboot[master]: drivers/intel/mipi_camera: Add support for dynamic SSDT generation

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45172 )

Change subject: drivers/intel/mipi_camera: Add support for dynamic SSDT generation
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45172/8/src/drivers/intel/mipi_came... 
File src/drivers/intel/mipi_camera/camera_sku.c:

https://review.coreboot.org/c/coreboot/+/45172/8/src/drivers/intel/mipi_came... 
PS8, Line 36: 	/* By default device will be set to enabled in alloc_dev. So calling dev_set_enabled
            : 	is not making call to chip_ops->enable_dev as device is already enabled */
            : 	dev_set_enabled(sensor, 0);
            : 	dev_set_enabled(sensor, 1);
            : }
This is a little confusing. You say that it's already enabled, and then you disable and re-enable it without explaining why you have to do that. Maybe reword the comment to explain why you have to disable it first, something like this?
"Disable and re-enable the device so that chip_ops->enable_dev will always get called."