Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52662 )
Change subject: sc7180: Add display support for mipi panels ......................................................................
Patch Set 13:
(15 comments)
File src/mainboard/google/trogdor/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120412): https://review.coreboot.org/c/coreboot/+/52662/comment/f52bedf0_3f3748f0 PS13, Line 104: if(CONFIG(TROGDOR_HAS_MIPI_PANEL)) space required before the open parenthesis '('
File src/soc/qualcomm/sc7180/display/dsi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120412): https://review.coreboot.org/c/coreboot/+/52662/comment/9f529d92_69aaa570 PS13, Line 65: write32(&dsi0->trig_ctrl,DSI_DMA_STREAM1 << 8 | DSI_DMA_TRIGGER_SEL); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120412): https://review.coreboot.org/c/coreboot/+/52662/comment/d13913ee_3c53063c PS13, Line 172: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120412): https://review.coreboot.org/c/coreboot/+/52662/comment/7c7ad333_c27f54e9 PS13, Line 210: printk(BIOS_ERR, Invalid vsprintf pointer extension '%pk'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120412): https://review.coreboot.org/c/coreboot/+/52662/comment/f03abc5b_0809075f PS13, Line 281: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120412): https://review.coreboot.org/c/coreboot/+/52662/comment/b1c78d19_26e35722 PS13, Line 289: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120412): https://review.coreboot.org/c/coreboot/+/52662/comment/63480036_395c9e60 PS13, Line 292: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120412): https://review.coreboot.org/c/coreboot/+/52662/comment/26087f9a_5800a819 PS13, Line 299: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120412): https://review.coreboot.org/c/coreboot/+/52662/comment/9e20cfc3_26c1f2ac PS13, Line 302: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120412): https://review.coreboot.org/c/coreboot/+/52662/comment/16f5d85d_fe6138b8 PS13, Line 319: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120412): https://review.coreboot.org/c/coreboot/+/52662/comment/c0f69241_67e1db92 PS13, Line 322: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_DMA_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120412): https://review.coreboot.org/c/coreboot/+/52662/comment/d29e9e69_36bc130d PS13, Line 325: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_MDP_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120412): https://review.coreboot.org/c/coreboot/+/52662/comment/6943a826_5bfd6c72 PS13, Line 328: setbits32(&dsi0->int_ctrl,DSI_VIDEO_MODE_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120412): https://review.coreboot.org/c/coreboot/+/52662/comment/fb296164_a2e95a16 PS13, Line 333: setbits32(&dsi0->int_ctrl,DSI_ERROR_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120412): https://review.coreboot.org/c/coreboot/+/52662/comment/38786374_009dad18 PS13, Line 343: if(!pinfo && !pinfo->init_cmd) space required before the open parenthesis '('
-
build bot (Jenkins) (Code Review)