Change in coreboot[master]: soc/amd/picasso: clean up Kconfig and header - coreboot-gerrit

23 Apr 2021


      Attention is currently required from: Jason Glenesk, Marshall Dawson, Kangheui Won, Angel Pons, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52563 )
Change subject: soc/amd/picasso: clean up Kconfig and header
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/52563/comment/37018ca9_17ca22ac 
PS1, Line 410: 0x3000
...
I think 0x8000(32KB) makes more sense here rather than 0x3000(12KB) since VB2_FIRMWARE_WORKBUF_RECOM […]
Ack
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52563
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib370d93e23c15a2fe4c46051ed3647d2d067bb10
Gerrit-Change-Number: 52563
Gerrit-PatchSet: 2
Gerrit-Owner: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Kangheui Won khwon@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 23 Apr 2021 14:35:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Kangheui Won khwon@chromium.org
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment