Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42568 )
Change subject: mb/google/zork: remove redundant IRQ routing configuration ......................................................................
mb/google/zork: remove redundant IRQ routing configuration
The PIC and APIC IRQ routing tables are pre-populated with PIRQ_NC in init_tables(), so the fch_pirq table entries where both IRQ numbers are set to fch_pirq are redundant and can be removed.
Change-Id: I0d9b4f25e12a66cf86d1ad541955c3d2fe336c5a Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/google/zork/mainboard.c 1 file changed, 0 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/42568/1
diff --git a/src/mainboard/google/zork/mainboard.c b/src/mainboard/google/zork/mainboard.c index c6b4bdd..b17c7f8 100644 --- a/src/mainboard/google/zork/mainboard.c +++ b/src/mainboard/google/zork/mainboard.c @@ -79,41 +79,13 @@ { PIRQ_B, 6, 17 }, { PIRQ_C, 14, 18 }, { PIRQ_D, 15, 19 }, - { PIRQ_E, PIRQ_NC, PIRQ_NC }, - { PIRQ_F, PIRQ_NC, PIRQ_NC }, - { PIRQ_G, PIRQ_NC, PIRQ_NC }, - { PIRQ_H, PIRQ_NC, PIRQ_NC }, - { PIRQ_SIRQA, PIRQ_NC, PIRQ_NC }, - { PIRQ_SIRQB, PIRQ_NC, PIRQ_NC }, - { PIRQ_SIRQC, PIRQ_NC, PIRQ_NC }, - { PIRQ_SIRQD, PIRQ_NC, PIRQ_NC }, { PIRQ_SCI, 9, 9 }, - { PIRQ_SMBUS, PIRQ_NC, PIRQ_NC }, - { PIRQ_ASF, PIRQ_NC, PIRQ_NC }, - { PIRQ_PMON, PIRQ_NC, PIRQ_NC }, - { PIRQ_SD, PIRQ_NC, PIRQ_NC }, - { PIRQ_SDIO, PIRQ_NC, PIRQ_NC }, - { PIRQ_CIR, PIRQ_NC, PIRQ_NC }, - { PIRQ_GPIOA, PIRQ_NC, PIRQ_NC }, - { PIRQ_GPIOB, PIRQ_NC, PIRQ_NC }, - { PIRQ_GPIOC, PIRQ_NC, PIRQ_NC }, - { PIRQ_SATA, PIRQ_NC, PIRQ_NC }, { PIRQ_EMMC, 5, 5 }, - { PIRQ_GPP0, PIRQ_NC, PIRQ_NC }, - { PIRQ_GPP1, PIRQ_NC, PIRQ_NC }, - { PIRQ_GPP2, PIRQ_NC, PIRQ_NC }, - { PIRQ_GPP3, PIRQ_NC, PIRQ_NC }, { PIRQ_GPIO, 7, 7 }, - { PIRQ_I2C0, PIRQ_NC, PIRQ_NC }, - { PIRQ_I2C1, PIRQ_NC, PIRQ_NC }, { PIRQ_I2C2, 10, 10 }, { PIRQ_I2C3, 11, 11 }, { PIRQ_UART0, 4, 4 }, { PIRQ_UART1, 3, 3 }, - { PIRQ_I2C4, PIRQ_NC, PIRQ_NC }, - { PIRQ_I2C5, PIRQ_NC, PIRQ_NC }, - { PIRQ_UART2, PIRQ_NC, PIRQ_NC }, - { PIRQ_UART3, PIRQ_NC, PIRQ_NC },
/* The MISC registers are not interrupt numbers */ { PIRQ_MISC, 0xfa, 0x00 },
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42568 )
Change subject: mb/google/zork: remove redundant IRQ routing configuration ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42568 )
Change subject: mb/google/zork: remove redundant IRQ routing configuration ......................................................................
mb/google/zork: remove redundant IRQ routing configuration
The PIC and APIC IRQ routing tables are pre-populated with PIRQ_NC in init_tables(), so the fch_pirq table entries where both IRQ numbers are set to fch_pirq are redundant and can be removed.
Change-Id: I0d9b4f25e12a66cf86d1ad541955c3d2fe336c5a Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/42568 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Raul Rangel rrangel@chromium.org --- M src/mainboard/google/zork/mainboard.c 1 file changed, 0 insertions(+), 28 deletions(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved
diff --git a/src/mainboard/google/zork/mainboard.c b/src/mainboard/google/zork/mainboard.c index c6b4bdd..b17c7f8 100644 --- a/src/mainboard/google/zork/mainboard.c +++ b/src/mainboard/google/zork/mainboard.c @@ -79,41 +79,13 @@ { PIRQ_B, 6, 17 }, { PIRQ_C, 14, 18 }, { PIRQ_D, 15, 19 }, - { PIRQ_E, PIRQ_NC, PIRQ_NC }, - { PIRQ_F, PIRQ_NC, PIRQ_NC }, - { PIRQ_G, PIRQ_NC, PIRQ_NC }, - { PIRQ_H, PIRQ_NC, PIRQ_NC }, - { PIRQ_SIRQA, PIRQ_NC, PIRQ_NC }, - { PIRQ_SIRQB, PIRQ_NC, PIRQ_NC }, - { PIRQ_SIRQC, PIRQ_NC, PIRQ_NC }, - { PIRQ_SIRQD, PIRQ_NC, PIRQ_NC }, { PIRQ_SCI, 9, 9 }, - { PIRQ_SMBUS, PIRQ_NC, PIRQ_NC }, - { PIRQ_ASF, PIRQ_NC, PIRQ_NC }, - { PIRQ_PMON, PIRQ_NC, PIRQ_NC }, - { PIRQ_SD, PIRQ_NC, PIRQ_NC }, - { PIRQ_SDIO, PIRQ_NC, PIRQ_NC }, - { PIRQ_CIR, PIRQ_NC, PIRQ_NC }, - { PIRQ_GPIOA, PIRQ_NC, PIRQ_NC }, - { PIRQ_GPIOB, PIRQ_NC, PIRQ_NC }, - { PIRQ_GPIOC, PIRQ_NC, PIRQ_NC }, - { PIRQ_SATA, PIRQ_NC, PIRQ_NC }, { PIRQ_EMMC, 5, 5 }, - { PIRQ_GPP0, PIRQ_NC, PIRQ_NC }, - { PIRQ_GPP1, PIRQ_NC, PIRQ_NC }, - { PIRQ_GPP2, PIRQ_NC, PIRQ_NC }, - { PIRQ_GPP3, PIRQ_NC, PIRQ_NC }, { PIRQ_GPIO, 7, 7 }, - { PIRQ_I2C0, PIRQ_NC, PIRQ_NC }, - { PIRQ_I2C1, PIRQ_NC, PIRQ_NC }, { PIRQ_I2C2, 10, 10 }, { PIRQ_I2C3, 11, 11 }, { PIRQ_UART0, 4, 4 }, { PIRQ_UART1, 3, 3 }, - { PIRQ_I2C4, PIRQ_NC, PIRQ_NC }, - { PIRQ_I2C5, PIRQ_NC, PIRQ_NC }, - { PIRQ_UART2, PIRQ_NC, PIRQ_NC }, - { PIRQ_UART3, PIRQ_NC, PIRQ_NC },
/* The MISC registers are not interrupt numbers */ { PIRQ_MISC, 0xfa, 0x00 },
-
Felix Held (Code Review) -
Raul Rangel (Code Review)