[XS] Change in coreboot[main]: ec/google: Assume LID open for platforms without VBOOT_LID_SWITCH

[Subrata Banik (Code Review)]

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Julius Werner, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro, Nick Vaccaro.

Hello Boris Mittelberg, Caveh Jalali, Julius Werner, Kapil Porwal, Nick Vaccaro, Nick Vaccaro, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/78077?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)


Change subject: ec/google: Assume LID open for platforms without VBOOT_LID_SWITCH
......................................................................

ec/google: Assume LID open for platforms without VBOOT_LID_SWITCH

This patch modifies the get_lid_switch() implementation to assume
the LID is open when VBOOT_LID_SWITCH is not enabled. This is
necessary for platforms that do not have a physical LID switch.

Additionally, change the return type of `get_lid_switch()` to
`uint32_t` to keep it aligned with value field in lb_gpio.

BUG=b:299137940
TEST=Able to build and boot google/ovis.

Change-Id: I34bfc21329660a4bfd1ffed939b6dfb7e7109204
Signed-off-by: Subrata Banik <[e-mail]>
---
M src/ec/google/chromeec/switches.c
M src/include/bootmode.h
M src/lib/bootmode.c
3 files changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/78077/2
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/78077?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I34bfc21329660a4bfd1ffed939b6dfb7e7109204
Gerrit-Change-Number: 78077
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <[e-mail]>
Gerrit-Reviewer: Boris Mittelberg <[e-mail]>
Gerrit-Reviewer: Caveh Jalali <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-Reviewer: Kapil Porwal <[e-mail]>
Gerrit-Reviewer: Nick Vaccaro <[e-mail]>
Gerrit-Reviewer: Nick Vaccaro <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Karthik Ramasubramanian <[e-mail]>
Gerrit-Attention: Caveh Jalali <[e-mail]>
Gerrit-Attention: Kapil Porwal <[e-mail]>
Gerrit-Attention: Nick Vaccaro <[e-mail]>
Gerrit-Attention: Julius Werner <[e-mail]>
Gerrit-Attention: Nick Vaccaro <[e-mail]>
Gerrit-Attention: Karthik Ramasubramanian <[e-mail]>
Gerrit-Attention: Boris Mittelberg <[e-mail]>
Gerrit-MessageType: newpatchset