[L] Change in coreboot[master]: [RFC] drivers/option: Add option list in cbtable

[Benjamin Doron (Code Review)]

Attention is currently required from: Sean Rhodes, Angel Pons, Maximilian Brune, Lean Sheng Tan.

Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 )

Change subject: [RFC] drivers/option: Add option list in cbtable
......................................................................


Patch Set 3:

(1 comment)

File src/drivers/option/cfr.c:

https://review.coreboot.org/c/coreboot/+/74121/comment/766719a1_5a9c2996 
PS3, Line 103: option_id
> Is this intended to be an index?
> I know it's used in EDK2's HII backend as the "question" identifier.

In CFR, I'd rather move it to the backend too, or establish that CFR should be sorted by these IDs. For instance, suppose the developer initialises and adds options in the order 1, 3, 2. At the moment, in EDK2, they're processed in struct-order not ID-order.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74121
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772
Gerrit-Change-Number: 74121
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons <[e-mail]>
Gerrit-Reviewer: Benjamin Doron <[e-mail]>
Gerrit-Reviewer: Maximilian Brune <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Daniel Maslowski <[e-mail]>
Gerrit-CC: Lean Sheng Tan <[e-mail]>
Gerrit-CC: Matt DeVillier <[e-mail]>
Gerrit-CC: Nico Huber <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-CC: Sean Rhodes <[e-mail]>
Gerrit-Attention: Sean Rhodes <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Maximilian Brune <[e-mail]>
Gerrit-Attention: Lean Sheng Tan <[e-mail]>
Gerrit-Comment-Date: Sun, 30 Apr 2023 17:53:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes <[e-mail]>
Gerrit-MessageType: comment