Change in coreboot[master]: src/lib/dimm_info_util.c: Add methods to convert from SMBIOS to SPD
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/25412 )
Change subject: src/lib/dimm_info_util.c: Add methods to convert from SMBIOS to SPD ......................................................................
Patch Set 1:
(7 comments)
https://review.coreboot.org/#/c/25412/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/25412/1//COMMIT_MSG@14 PS1, Line 14: Tested on grunt Say something better. How did you tested? Using code not present in the commit? Will this code be committed separately? The reader needs to understand how it was tested.
https://review.coreboot.org/#/c/25412/1/src/include/dimm_info_util.h File src/include/dimm_info_util.h:
https://review.coreboot.org/#/c/25412/1/src/include/dimm_info_util.h@4 PS1, Line 4: Inc LLC
https://review.coreboot.org/#/c/25412/1/src/include/dimm_info_util.h@38 PS1, Line 38: /** Empty line before a comment. It's ok to place prototypes together if they don't have a comment describing them.
https://review.coreboot.org/#/c/25412/1/src/lib/dimm_info_util.c File src/lib/dimm_info_util.c:
https://review.coreboot.org/#/c/25412/1/src/lib/dimm_info_util.c@4 PS1, Line 4: Inc LLC
https://review.coreboot.org/#/c/25412/1/src/lib/dimm_info_util.c@74 PS1, Line 74: else if Just an "if" is enough because if there is a match in the previous "if" it returns and never reaches the else.
https://review.coreboot.org/#/c/25412/1/src/lib/dimm_info_util.c@77 PS1, Line 77: else if Just an "if" is enough because if there is a match in the previous "if" it returns and never reaches the else.
https://review.coreboot.org/#/c/25412/1/src/lib/dimm_info_util.c@80 PS1, Line 80: else No need of "else". It will only reach here if there was no previous match.
-
Richard Spiegel (Code Review)