Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46858 )
Change subject: drivers/wifi/generic: Use acpigen_write_ADR_pci_device ......................................................................
drivers/wifi/generic: Use acpigen_write_ADR_pci_device
This change uses the helper function `acpigen_write_ADR_pci_device()` to write _ADR object for the WiFi device.
Change-Id: I3ba38f3ec4d8024209840e93bebf2d39bbef7685 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/drivers/wifi/generic/generic.c 1 file changed, 1 insertion(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/46858/1
diff --git a/src/drivers/wifi/generic/generic.c b/src/drivers/wifi/generic/generic.c index e8184d8..6ffa7f1 100644 --- a/src/drivers/wifi/generic/generic.c +++ b/src/drivers/wifi/generic/generic.c @@ -170,7 +170,6 @@ static void wifi_generic_fill_ssdt(const struct device *dev) { const char *path; - u32 address; const struct drivers_wifi_generic_config *config = dev->chip_info;
if (!dev->enabled) @@ -189,10 +188,7 @@ acpigen_write_name_string("_DDN", dev->chip_ops->name);
/* Address */ - address = PCI_SLOT(dev->path.pci.devfn) & 0xffff; - address <<= 16; - address |= PCI_FUNC(dev->path.pci.devfn) & 0xffff; - acpigen_write_name_dword("_ADR", address); + acpigen_write_ADR_pci_device(dev);
/* Wake capabilities */ if (config)
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46858 )
Change subject: drivers/wifi/generic: Use acpigen_write_ADR_pci_device ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46858 )
Change subject: drivers/wifi/generic: Use acpigen_write_ADR_pci_device ......................................................................
drivers/wifi/generic: Use acpigen_write_ADR_pci_device
This change uses the helper function `acpigen_write_ADR_pci_device()` to write _ADR object for the WiFi device.
Change-Id: I3ba38f3ec4d8024209840e93bebf2d39bbef7685 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46858 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Duncan Laurie dlaurie@chromium.org --- M src/drivers/wifi/generic/generic.c 1 file changed, 1 insertion(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved
diff --git a/src/drivers/wifi/generic/generic.c b/src/drivers/wifi/generic/generic.c index e8184d8..6ffa7f1 100644 --- a/src/drivers/wifi/generic/generic.c +++ b/src/drivers/wifi/generic/generic.c @@ -170,7 +170,6 @@ static void wifi_generic_fill_ssdt(const struct device *dev) { const char *path; - u32 address; const struct drivers_wifi_generic_config *config = dev->chip_info;
if (!dev->enabled) @@ -189,10 +188,7 @@ acpigen_write_name_string("_DDN", dev->chip_ops->name);
/* Address */ - address = PCI_SLOT(dev->path.pci.devfn) & 0xffff; - address <<= 16; - address |= PCI_FUNC(dev->path.pci.devfn) & 0xffff; - acpigen_write_name_dword("_ADR", address); + acpigen_write_ADR_pci_device(dev);
/* Wake capabilities */ if (config)
-
Duncan Laurie (Code Review) -
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)