Change in coreboot[master]: soc/intel: Drop copy-pasted `MSR_VR_MISC_CONFIG2` define

[Subrata Banik (Code Review)]

Attention is currently required from: Jeff Daly, Mariusz Szafrański, Tim Wawrzynczak, Suresh Bellampalli, Vanessa Eusebio, Angel Pons, Arthur Heymans.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63367 )

Change subject: soc/intel: Drop copy-pasted `MSR_VR_MISC_CONFIG2` define
......................................................................


Patch Set 1:

(1 comment)

File src/soc/intel/alderlake/include/soc/msr.h:

https://review.coreboot.org/c/coreboot/+/63367/comment/f75d48d4_6a2dcb37 
PS1, Line 10: MSR_VR_MISC_CONFIG2
> Yeah I see it defined in the EDS, but FSP does not program it, and neither does coreboot.

Yes, for that, the commit msg need to be updated to reflect the same "The `MSR_VR_MISC_CONFIG2` was copy-pasted from Haswell/Broadwell code, but newer processors never used MSR 0x636, hence dropping with this code change".

"newer processors don't have this MSR." => I read this as EDS doesn't have this MSR defined.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63367
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b203aa243ab97e3569f7347b424dd72318bd65f
Gerrit-Change-Number: 63367
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Jeff Daly <[e-mail]>
Gerrit-Reviewer: Mariusz Szafrański <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: Suresh Bellampalli <[e-mail]>
Gerrit-Reviewer: Tim Wawrzynczak <[e-mail]>
Gerrit-Reviewer: Vanessa Eusebio <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Jeff Daly <[e-mail]>
Gerrit-Attention: Mariusz Szafrański <[e-mail]>
Gerrit-Attention: Tim Wawrzynczak <[e-mail]>
Gerrit-Attention: Suresh Bellampalli <[e-mail]>
Gerrit-Attention: Vanessa Eusebio <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Arthur Heymans <[e-mail]>
Gerrit-Comment-Date: Tue, 05 Apr 2022 14:30:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <[e-mail]>
Comment-In-Reply-To: Tim Wawrzynczak <[e-mail]>
Gerrit-MessageType: comment