Change in coreboot[master]: cbfstool: MediaTek: Hash bootblock.bin for CBFS_VERIFICATION
Attention is currently required from: Hung-Te Lin, Paul Menzel, Julius Werner. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63925 )
Change subject: cbfstool: MediaTek: Hash bootblock.bin for CBFS_VERIFICATION ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63925/comment/2a391c6a_335eda0c PS3, Line 7: cbfstool: Add MediaTek fixup
Maybe more specific: […]
Done
https://review.coreboot.org/c/coreboot/+/63925/comment/7a3dfd5e_2850aeac PS3, Line 9: bootROM
Is that the official spelling?
According to https://en.wikipedia.org/wiki/Boot_ROM both "boot ROM" or "bootROM" are valid.
File util/cbfstool/platform_fixups.c:
https://review.coreboot.org/c/coreboot/+/63925/comment/8947979a_8b79204f PS3, Line 151: ERROR("fixups: MediaTek data size too small: %zu\n", data_size);
Add a colon after MediaTek, so it doesn’t read as a sentence?
Done
https://review.coreboot.org/c/coreboot/+/63925/comment/a91b33fa_8ed65fde PS3, Line 173: int
bool?
Oops.
-
Yu-Ping Wu (Code Review)