Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Chris Wang, Patrick Huang.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52544 )
Change subject: src/vendorcode/amd/fsp/picasso: Add HDMI 2.0 diable setting section of FspmUpd.h
......................................................................
Patch Set 7:
(1 comment)
File src/vendorcode/amd/fsp/picasso/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/52544/comment/dcf39ddf_e805254f
PS7, Line 67: UnusedUpdSpace1
this one seems to be defined and used in fsp, so i'd add that one in a patch before this one
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52544
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie00389074f3718a23440c41ae0b116455aa8b603
Gerrit-Change-Number: 52544
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Huang
patrick.huang@amd.corp-partner.google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: chris wang
Chris.Wang@amd.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Patrick Huang
patrick.huang@amd.corp-partner.google.com
Gerrit-Comment-Date: Thu, 22 Apr 2021 15:22:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment