Change in coreboot[master]: src/soc/intel/icelake: Allow option to use USE_INTEL_FSP_MP_INIT

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44062 )

Change subject: src/soc/intel/icelake: Allow option to use USE_INTEL_FSP_MP_INIT
......................................................................

src/soc/intel/icelake: Allow option to use USE_INTEL_FSP_MP_INIT

This patch removes the unnecessary enforcement of MP PPI in ICL
in order to have parity with other IA-SoC.

Now it allows user to select USE_INTEL_FSP_MP_INIT if required.

TEST=Able to build and boot ICL platform with either USE_INTEL_FSP_MP_INIT
or USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI selected.

Change-Id: I25288a24cdf9dceec45a90e4e7233225a6cab508
Signed-off-by: Subrata Banik 
---
M src/soc/intel/icelake/fsp_params.c
1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/44062/1

diff --git a/src/soc/intel/icelake/fsp_params.c b/src/soc/intel/icelake/fsp_params.c
index d4485c6..0130d2c 100644
--- a/src/soc/intel/icelake/fsp_params.c
+++ b/src/soc/intel/icelake/fsp_params.c
@@ -71,8 +71,9 @@
    for (i = 0; i < ARRAY_SIZE(params->Usb3OverCurrentPin); i++)
    	params->Usb3OverCurrentPin[i] = 0;

-	/* Mandatory to make use of CpuMpPpi implementation from ICL onwards */
-	params->CpuMpPpi = (uintptr_t) mp_fill_ppi_services_data();
+	/* Use coreboot MP PPI services if Kconfig is enabled */
+	if (CONFIG(USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI))
+		params->CpuMpPpi = (uintptr_t) mp_fill_ppi_services_data();

mainboard_silicon_init_params(params);

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44062 )

Change subject: src/soc/intel/icelake: Allow option to use USE_INTEL_FSP_MP_INIT
......................................................................

Patch Set 1: Code-Review+1

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44062 )

Change subject: src/soc/intel/icelake: Allow option to use USE_INTEL_FSP_MP_INIT
......................................................................

Patch Set 1:

Any further review here ?

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44062 )

Change subject: src/soc/intel/icelake: Allow option to use USE_INTEL_FSP_MP_INIT
......................................................................

Patch Set 1: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44062 )

Change subject: src/soc/intel/icelake: Allow option to use USE_INTEL_FSP_MP_INIT
......................................................................

Patch Set 1: Code-Review+2

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44062 )

Change subject: src/soc/intel/icelake: Allow option to use USE_INTEL_FSP_MP_INIT
......................................................................

src/soc/intel/icelake: Allow option to use USE_INTEL_FSP_MP_INIT

This patch removes the unnecessary enforcement of MP PPI in ICL
in order to have parity with other IA-SoC.

Now it allows user to select USE_INTEL_FSP_MP_INIT if required.

TEST=Able to build and boot ICL platform with either USE_INTEL_FSP_MP_INIT
or USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI selected.

Change-Id: I25288a24cdf9dceec45a90e4e7233225a6cab508
Signed-off-by: Subrata Banik 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44062
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
Reviewed-by: Aamir Bohra 
Reviewed-by: Furquan Shaikh 
---
M src/soc/intel/icelake/fsp_params.c
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Aamir Bohra: Looks good to me, approved
  Angel Pons: Looks good to me, but someone else must approve

diff --git a/src/soc/intel/icelake/fsp_params.c b/src/soc/intel/icelake/fsp_params.c
index d4485c6..0130d2c 100644
--- a/src/soc/intel/icelake/fsp_params.c
+++ b/src/soc/intel/icelake/fsp_params.c
@@ -71,8 +71,9 @@
    for (i = 0; i < ARRAY_SIZE(params->Usb3OverCurrentPin); i++)
    	params->Usb3OverCurrentPin[i] = 0;

-	/* Mandatory to make use of CpuMpPpi implementation from ICL onwards */
-	params->CpuMpPpi = (uintptr_t) mp_fill_ppi_services_data();
+	/* Use coreboot MP PPI services if Kconfig is enabled */
+	if (CONFIG(USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI))
+		params->CpuMpPpi = (uintptr_t) mp_fill_ppi_services_data();

mainboard_silicon_init_params(params);