Attention is currently required from: Raul Rangel, Jakub Czapiga, Karthik Ramasubramanian.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58805 )
Change subject: lib/list: Add list_append
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
I mean, there's nothing wrong with adding this, but why not just add new elements in your cbfs_preload use case to the front of the list (with list_insert_after(&list_head))? Should come out to roughly the same in the end.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58805
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1792e40f789e3ef16ceca65ce4cae946e08583d1
Gerrit-Change-Number: 58805
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 02 Nov 2021 01:09:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment