Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41983 )
Change subject: mb/google/foster: Remove EC_GOOGLE_CHROMEEC stubs ......................................................................
mb/google/foster: Remove EC_GOOGLE_CHROMEEC stubs
Board does not have ChromeEC.
Change-Id: Id6ab2495d6e082fdcb71ec5162efde877d97ce22 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/google/foster/chromeos.c D src/mainboard/google/foster/ec_dummy.c 2 files changed, 0 insertions(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/41983/1
diff --git a/src/mainboard/google/foster/chromeos.c b/src/mainboard/google/foster/chromeos.c index 6f7f09c..8dc236e 100644 --- a/src/mainboard/google/foster/chromeos.c +++ b/src/mainboard/google/foster/chromeos.c @@ -1,10 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <boot/coreboot_tables.h> -#include <ec/google/chromeec/ec.h> -#include <ec/google/chromeec/ec_commands.h> #include <gpio.h> -#include <vendorcode/google/chromeos/chromeos.h>
void fill_lb_gpios(struct lb_gpios *gpios) { @@ -21,15 +18,7 @@
int get_recovery_mode_switch(void) { -#if CONFIG(EC_GOOGLE_CHROMEEC) - uint64_t ec_events; - - ec_events = google_chromeec_get_events_b(); - return !!(ec_events & - EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY)); -#else return 0; -#endif }
int get_write_protect_state(void) diff --git a/src/mainboard/google/foster/ec_dummy.c b/src/mainboard/google/foster/ec_dummy.c deleted file mode 100644 index d96a258..0000000 --- a/src/mainboard/google/foster/ec_dummy.c +++ /dev/null @@ -1,11 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -/* Dummy CHROMEEC file to provide stub functions for vboot compilation */ - -#include <stdint.h> - -int google_chromeec_vbnv_context(int is_read, uint8_t *data, int len); -int google_chromeec_vbnv_context(int is_read, uint8_t *data, int len) -{ - return 0; -}
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41983
to look at the new patch set (#2).
Change subject: mb/google/foster: Remove EC_GOOGLE_CHROMEEC stubs ......................................................................
mb/google/foster: Remove EC_GOOGLE_CHROMEEC stubs
Board does not have ChromeEC.
Change-Id: Id6ab2495d6e082fdcb71ec5162efde877d97ce22 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/google/foster/chromeos.c D src/mainboard/google/foster/ec_dummy.c 2 files changed, 0 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/41983/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41983 )
Change subject: mb/google/foster: Remove EC_GOOGLE_CHROMEEC stubs ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41983 )
Change subject: mb/google/foster: Remove EC_GOOGLE_CHROMEEC stubs ......................................................................
mb/google/foster: Remove EC_GOOGLE_CHROMEEC stubs
Board does not have ChromeEC.
Change-Id: Id6ab2495d6e082fdcb71ec5162efde877d97ce22 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41983 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/google/foster/chromeos.c D src/mainboard/google/foster/ec_dummy.c 2 files changed, 0 insertions(+), 21 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/mainboard/google/foster/chromeos.c b/src/mainboard/google/foster/chromeos.c index 6f7f09c..38d12cb 100644 --- a/src/mainboard/google/foster/chromeos.c +++ b/src/mainboard/google/foster/chromeos.c @@ -1,8 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <boot/coreboot_tables.h> -#include <ec/google/chromeec/ec.h> -#include <ec/google/chromeec/ec_commands.h> #include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h>
@@ -21,15 +19,7 @@
int get_recovery_mode_switch(void) { -#if CONFIG(EC_GOOGLE_CHROMEEC) - uint64_t ec_events; - - ec_events = google_chromeec_get_events_b(); - return !!(ec_events & - EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY)); -#else return 0; -#endif }
int get_write_protect_state(void) diff --git a/src/mainboard/google/foster/ec_dummy.c b/src/mainboard/google/foster/ec_dummy.c deleted file mode 100644 index d96a258..0000000 --- a/src/mainboard/google/foster/ec_dummy.c +++ /dev/null @@ -1,11 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -/* Dummy CHROMEEC file to provide stub functions for vboot compilation */ - -#include <stdint.h> - -int google_chromeec_vbnv_context(int is_read, uint8_t *data, int len); -int google_chromeec_vbnv_context(int is_read, uint8_t *data, int len) -{ - return 0; -}
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41983 )
Change subject: mb/google/foster: Remove EC_GOOGLE_CHROMEEC stubs ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4767 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4766 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4765 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4764
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)