Change in coreboot[master]: util/bincfg: Add MAC address example to gbe-ich9m.set

[Evgeny Zinoviev (Code Review)]

Evgeny Zinoviev has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39664 )

Change subject: util/bincfg: Add MAC address example to gbe-ich9m.set
......................................................................

util/bincfg: Add MAC address example to gbe-ich9m.set

It's not obvious how to set specific byte of a multi-byte field in the
set file. Add an example (and a template) for setting MAC address.

Change-Id: Iea983071682ffebd61757497d43c70cc8214043d
Signed-off-by: Evgeny Zinoviev 
---
M util/bincfg/gbe-ich9m.set
1 file changed, 9 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/39664/1

diff --git a/util/bincfg/gbe-ich9m.set b/util/bincfg/gbe-ich9m.set
index 01f85ab..9c5515e 100644
--- a/util/bincfg/gbe-ich9m.set
+++ b/util/bincfg/gbe-ich9m.set
@@ -84,5 +84,13 @@
    "ssdid" = 0x20ee,
    "ssvid" = 0x17aa,
    "did" = 0x10f5,
-	"vid" = 0x8086
+	"vid" = 0x8086,
+
+	# MAC address
+	"macaddress0" = 0,
+	"macaddress1" = 0,
+	"macaddress2" = 0,
+	"macaddress3" = 0,
+	"macaddress4" = 0,
+	"macaddress5" = 0
 }

[Evgeny Zinoviev (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39664

to look at the new patch set (#2).

Change subject: util/bincfg: Add MAC address example to gbe-ich9m.set
......................................................................

util/bincfg: Add MAC address example to gbe-ich9m.set

It's not obvious how to set specific byte of a multi-byte field in the
set file. Add an example (and a template) for setting MAC address.

Change-Id: Iea983071682ffebd61757497d43c70cc8214043d
Signed-off-by: Evgeny Zinoviev 
---
M util/bincfg/gbe-ich9m.set
1 file changed, 9 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/39664/2

[Swift Geek (Sebastian Grzywna) (Code Review)]

Swift Geek (Sebastian Grzywna) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39664 )

Change subject: util/bincfg: Add MAC address example to gbe-ich9m.set
......................................................................

Patch Set 2: Code-Review+1

Tested on ThinkPad X200, connects to network fine even with that bogus MAC

[Angel Pons (Code Review)]

Attention is currently required from: Nico Huber, Evgeny Zinoviev.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39664 )

Change subject: util/bincfg: Add MAC address example to gbe-ich9m.set
......................................................................

Patch Set 2: Code-Review+2

[Jacob Garber (Code Review)]

Attention is currently required from: Nico Huber, Evgeny Zinoviev.
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39664 )

Change subject: util/bincfg: Add MAC address example to gbe-ich9m.set
......................................................................

Patch Set 2: Code-Review+2

(1 comment)

Patchset:

PS2: 
Tested on T500, Ethernet works fine.

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39664 )

Change subject: util/bincfg: Add MAC address example to gbe-ich9m.set
......................................................................

util/bincfg: Add MAC address example to gbe-ich9m.set

It's not obvious how to set specific byte of a multi-byte field in the
set file. Add an example (and a template) for setting MAC address.

Change-Id: Iea983071682ffebd61757497d43c70cc8214043d
Signed-off-by: Evgeny Zinoviev 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39664
Tested-by: build bot (Jenkins) 
Reviewed-by: Swift Geek (Sebastian Grzywna) 
Reviewed-by: Angel Pons 
Reviewed-by: Jacob Garber 
---
M util/bincfg/gbe-ich9m.set
1 file changed, 9 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Swift Geek (Sebastian Grzywna): Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved
  Jacob Garber: Looks good to me, approved

diff --git a/util/bincfg/gbe-ich9m.set b/util/bincfg/gbe-ich9m.set
index 3525470..f324a55 100644
--- a/util/bincfg/gbe-ich9m.set
+++ b/util/bincfg/gbe-ich9m.set
@@ -72,5 +72,13 @@
    "ssdid" = 0x20ee,
    "ssvid" = 0x17aa,
    "did" = 0x10f5,
-	"vid" = 0x8086
+	"vid" = 0x8086,
+
+	# This example sets MAC address to 00:11:22:33:44:55
+	"macaddress0" = 0x00,
+	"macaddress1" = 0x11,
+	"macaddress2" = 0x22,
+	"macaddress3" = 0x33,
+	"macaddress4" = 0x44,
+	"macaddress5" = 0x55
 }