Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans, Keith Hui.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61540 )
Change subject: mb/asus/p8x7x-series: Refactor mainboard_get_spd()
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/asus/p8x7x-series/variants/p8c_ws/early_init.c:
https://review.coreboot.org/c/coreboot/+/61540/comment/bf90646f_692de090
PS4, Line 5: #include <northbridge/intel/sandybridge/raminit_native.h>
Correct, but as you can see in this thread, Angel wants to see them removed in a separate commit.
sounds odd to me.
Angel, why do you want a separate commit?
the header is used for removed function.
now it is not used anymore.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61540
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b9c616a6c722e1f0fc124ced225efdcadb46b25
Gerrit-Change-Number: 61540
Gerrit-PatchSet: 4
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Comment-Date: Tue, 28 Feb 2023 23:27:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Keith Hui
buurin@gmail.com
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment