Attention is currently required from: David Wu, Morris Hsu, Nick Vaccaro, Paul Menzel, Subrata Banik.
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79735?usp=email )
Change subject: mb/google/nissa/var/craask: Add ILTK touchscreen
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79735/comment/275a1cd6_d1b5e39f :
PS4, Line 9: Add touchscreen ILTK for craaskwell
Please mention the datasheet name and version.
Add the information.
https://review.coreboot.org/c/coreboot/+/79735/comment/b2aaae11_3b6fa439 :
PS4, Line 12: TEST=build and check touchscreen function on craask
Is the Linux boot delayed by 200 ms during ACPI initialization?
Yes. It's will have 200ms delay time during ACPI initiallization.
Refer to spec. T2+T3 = 200ms.
File src/mainboard/google/brya/variants/craask/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79735/comment/77424370_d034b88d :
PS4, Line 400: register "generic.reset_delay_ms" = "200"
Where did you get the delay values from?
The delay time setting is from spec and other project settings.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79735?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6a68855b1659ff0c9cd33a0ec9acbd289f525a3d
Gerrit-Change-Number: 79735
Gerrit-PatchSet: 5
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Morris Hsu
morris-hsu@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Morris Hsu
morris-hsu@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 28 Dec 2023 09:27:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment