Attention is currently required from: Cliff Huang, Jérémy Compostella, Pranava Y N, Wonkyu Kim.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84405?usp=email )
Change subject: mb/google/fatcat: Add GPIO settings ......................................................................
Patch Set 22:
(2 comments)
File src/mainboard/google/fatcat/variants/fatcat/gpio.c:
https://review.coreboot.org/c/coreboot/+/84405/comment/f273b6e4_72c3beab?usp... : PS1, Line 440: /* GPP_C05: CRD1_PWREN */
We will need fw_config for camera1 & 2. I created tables are ready in https://review.coreboot.org/c/coreboot/+/84408/19.
can you please clarify what you mean by CAMERA 1 and CAMERA 2? are you referring to camera interface like MIPI vs USB here ? or UFC vs WFC?
we would like to keep both UFC and WFC enabled but I agree with you that we need one more FW config to disable UFC/WFC interface for lab deployment.
File src/mainboard/google/fatcat/variants/fatcat/gpio.c:
https://review.coreboot.org/c/coreboot/+/84405/comment/7f23c6e0_778a46ee?usp... : PS21, Line 253: overridden via fw_config
Subrata, How about changing to 'fw_config: <field name>'? Initially, I thought we wanted to remove those pads from the ramstage table and then found out that the pad needs to be in the table in order for fw_config to override. If the pad does not in the table, the override won't happen. I can also remove these additional comments entirely. In fact, it makes us easier since the pads including their comment are generated by a script.
I mean, we don't need such commenting in this file
-
Subrata Banik (Code Review)