Change in coreboot[master]: mb/google/dedede/var/madoo: Update Goodix touchscreen power sequence
Dtrain Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49011 )
Change subject: mb/google/dedede/var/madoo: Update Goodix touchscreen power sequence ......................................................................
mb/google/dedede/var/madoo: Update Goodix touchscreen power sequence
Follow Goodix datasheet (GT7375 Programming Guide_Rev.0.1.pdf and GT7375P Programming Guide_Rev.0.6.pdf) to tune touchscreen power sequence. Increase reset_delay_ms from 120ms to 180ms.
BUG=b:176511605 BRANCH=dedede TEST=Build and boot Madoo to OS
Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: Iae35e4da31a3c3afd24c7daf81a5a3e762acd3b4 --- M src/mainboard/google/dedede/variants/madoo/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/49011/1
diff --git a/src/mainboard/google/dedede/variants/madoo/overridetree.cb b/src/mainboard/google/dedede/variants/madoo/overridetree.cb index 993bfbb..e754882 100644 --- a/src/mainboard/google/dedede/variants/madoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/madoo/overridetree.cb @@ -122,7 +122,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" - register "generic.reset_delay_ms" = "120" + register "generic.reset_delay_ms" = "180" register "generic.reset_off_delay_ms" = "2" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" register "generic.enable_delay_ms" = "12"
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49011 )
Change subject: mb/google/dedede/var/madoo: Update Goodix touchscreen power sequence ......................................................................
Patch Set 1: Code-Review+1
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49011 )
Change subject: mb/google/dedede/var/madoo: Update Goodix touchscreen power sequence ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49011 )
Change subject: mb/google/dedede/var/madoo: Update Goodix touchscreen power sequence ......................................................................
mb/google/dedede/var/madoo: Update Goodix touchscreen power sequence
Follow Goodix datasheet (GT7375 Programming Guide_Rev.0.1.pdf and GT7375P Programming Guide_Rev.0.6.pdf) to tune touchscreen power sequence. Increase reset_delay_ms from 120ms to 180ms.
BUG=b:176511605 BRANCH=dedede TEST=Build and boot Madoo to OS
Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: Iae35e4da31a3c3afd24c7daf81a5a3e762acd3b4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/49011 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com --- M src/mainboard/google/dedede/variants/madoo/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified EricR Lai: Looks good to me, approved Dtrain Hsu: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/variants/madoo/overridetree.cb b/src/mainboard/google/dedede/variants/madoo/overridetree.cb index 993bfbb..e754882 100644 --- a/src/mainboard/google/dedede/variants/madoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/madoo/overridetree.cb @@ -122,7 +122,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" - register "generic.reset_delay_ms" = "120" + register "generic.reset_delay_ms" = "180" register "generic.reset_off_delay_ms" = "2" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" register "generic.enable_delay_ms" = "12"
-
Dtrain Hsu (Code Review) -
EricR Lai (Code Review)
-
Patrick Georgi (Code Review)