Attention is currently required from: Jan Philipp Groß, Máté Kukri, Nicholas Chin.
Angel Pons has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/85884?usp=email )
Change subject: mb/asrock: Add Z87M Extreme4 (Haswell) ......................................................................
Patch Set 3: Code-Review+1
(3 comments)
File src/mainboard/asrock/z87m_extreme4/bootblock.c:
https://review.coreboot.org/c/coreboot/+/85884/comment/d41d8155_cc3ab98f?usp... : PS3, Line 12: nit: drop one blank line
File src/mainboard/asrock/z87m_extreme4/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/85884/comment/ff8dffa6_2b373bff?usp... : PS3, Line 25: /* FIXME: remove this if the board doesn't have backlight. */ : #include <drivers/intel/gma/acpi/default_brightness_levels.asl> Yeet
File src/mainboard/asrock/z87m_extreme4/romstage.c:
https://review.coreboot.org/c/coreboot/+/85884/comment/4173836c_78681f24?usp... : PS3, Line 11: /* FIXME: called after romstage_common, remove it if not used */ : void mb_late_romstage_setup(void) : { : } Yeet