Change in coreboot[master]: mb/google/puff/var/dooly: Set I2C0 SerialIoDevMode to PchSerialIoPci
Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49081 )
Change subject: mb/google/puff/var/dooly: Set I2C0 SerialIoDevMode to PchSerialIoPci ......................................................................
mb/google/puff/var/dooly: Set I2C0 SerialIoDevMode to PchSerialIoPci
I2C0 has amplified connected, thus set it to PchSerialIoPci
BUG=b:170273526 BRANCH=puff TEST=Build and check DUT boot to OS
Change-Id: I9540f7b5538d37de53bcf43531488d714874a565 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/dooly/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/49081/1
diff --git a/src/mainboard/google/hatch/variants/dooly/overridetree.cb b/src/mainboard/google/hatch/variants/dooly/overridetree.cb index 45c43cc..69d1428 100644 --- a/src/mainboard/google/hatch/variants/dooly/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dooly/overridetree.cb @@ -9,7 +9,7 @@ register "TetonGlacierMode" = "1"
register "SerialIoDevMode" = "{ - [PchSerialIoIndexI2C0] = PchSerialIoDisabled, + [PchSerialIoIndexI2C0] = PchSerialIoPci, [PchSerialIoIndexI2C1] = PchSerialIoDisabled, [PchSerialIoIndexI2C2] = PchSerialIoPci, [PchSerialIoIndexI2C3] = PchSerialIoPci,
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49081 )
Change subject: mb/google/puff/var/dooly: Set I2C0 SerialIoDevMode to PchSerialIoPci ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/49081/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49081/1//COMMIT_MSG@9 PS1, Line 9: I2C0 has amplified connected, thus set it to PchSerialIoPci Please add a period/dot at the end of sentences.
https://review.coreboot.org/c/coreboot/+/49081/1//COMMIT_MSG@9 PS1, Line 9: connected connection?
https://review.coreboot.org/c/coreboot/+/49081/1//COMMIT_MSG@13 PS1, Line 13: TEST=Build and check DUT boot to OS What works now?
Hello Sam McNally, build bot (Jenkins), Paul Menzel, Edward O'Callaghan, Wisley Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49081
to look at the new patch set (#2).
Change subject: mb/google/puff/var/dooly: Config I2C0 SerialIoDevMode ......................................................................
mb/google/puff/var/dooly: Config I2C0 SerialIoDevMode
I2C0 has amplifier connection, thus set it to PchSerialIoPci
BUG=b:170273526 BRANCH=puff TEST=Build and check PCH serial IO config is set I2C0 to Mode 1
Change-Id: I9540f7b5538d37de53bcf43531488d714874a565 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/dooly/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/49081/2
Hello Sam McNally, build bot (Jenkins), Paul Menzel, Edward O'Callaghan, Wisley Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49081
to look at the new patch set (#3).
Change subject: mb/google/puff/var/dooly: Config I2C0 SerialIoDevMode ......................................................................
mb/google/puff/var/dooly: Config I2C0 SerialIoDevMode
I2C0 has amplifier connection, thus set it to PchSerialIoPci.
BUG=b:170273526 BRANCH=puff TEST=Build and check PCH serial IO config is set I2C0 to Mode 1
Change-Id: I9540f7b5538d37de53bcf43531488d714874a565 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/dooly/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/49081/3
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49081 )
Change subject: mb/google/puff/var/dooly: Config I2C0 SerialIoDevMode ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/49081/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49081/1//COMMIT_MSG@9 PS1, Line 9: connected
connection?
Done
https://review.coreboot.org/c/coreboot/+/49081/1//COMMIT_MSG@9 PS1, Line 9: I2C0 has amplified connected, thus set it to PchSerialIoPci
Please add a period/dot at the end of sentences.
Done
https://review.coreboot.org/c/coreboot/+/49081/1//COMMIT_MSG@13 PS1, Line 13: TEST=Build and check DUT boot to OS
What works now?
Done
Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49081 )
Change subject: mb/google/puff/var/dooly: Config I2C0 SerialIoDevMode ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49081 )
Change subject: mb/google/puff/var/dooly: Config I2C0 SerialIoDevMode ......................................................................
mb/google/puff/var/dooly: Config I2C0 SerialIoDevMode
I2C0 has amplifier connection, thus set it to PchSerialIoPci.
BUG=b:170273526 BRANCH=puff TEST=Build and check PCH serial IO config is set I2C0 to Mode 1
Change-Id: I9540f7b5538d37de53bcf43531488d714874a565 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49081 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Sam McNally sammc@google.com --- M src/mainboard/google/hatch/variants/dooly/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Sam McNally: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/dooly/overridetree.cb b/src/mainboard/google/hatch/variants/dooly/overridetree.cb index 45c43cc..69d1428 100644 --- a/src/mainboard/google/hatch/variants/dooly/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dooly/overridetree.cb @@ -9,7 +9,7 @@ register "TetonGlacierMode" = "1"
register "SerialIoDevMode" = "{ - [PchSerialIoIndexI2C0] = PchSerialIoDisabled, + [PchSerialIoIndexI2C0] = PchSerialIoPci, [PchSerialIoIndexI2C1] = PchSerialIoDisabled, [PchSerialIoIndexI2C2] = PchSerialIoPci, [PchSerialIoIndexI2C3] = PchSerialIoPci,
-
Patrick Georgi (Code Review) -
Paul Menzel (Code Review)
-
Sam McNally (Code Review)
-
Tony Huang (Code Review)