Attention is currently required from: Michał Żygowski.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67975 )
Change subject: soc/intel/cmn/gfx: Add missing CML-U IGD device IDs ......................................................................
Patch Set 4: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67975/comment/3f3af00f_ea39f869 PS4, Line 11: ID nit: IDs
https://review.coreboot.org/c/coreboot/+/67975/comment/55981504_6801574e PS4, Line 16: 1021U typo: 1021*0*U
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/67975/comment/3936e382_ae37ca75 PS4, Line 3930: #define PCI_DID_INTEL_CML_GT2_ULT_7 0x9BCC Why are the hex values yelling? At least that's what reading hex values in UPPERCASE feels like. If anyone's bored, feel free to change them to lowercase.
-
Angel Pons (Code Review)