[S] Change in coreboot[main]: cbmem.h: Drop cbmem_possible_online in favor of ENV_HAS_CBMEM - coreboot-gerrit

31 Oct 2023


      Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77166?usp=email )
Change subject: cbmem.h: Drop cbmem_possible_online in favor of ENV_HAS_CBMEM
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
...
...
Looks like the definitions for `cbmem_possibly_online()` and `ENV_HAS_CBMEM` were not the same? `E […]
Fair enough, guess you're right. I remembered that some boards access CBFS from SMM (which in itself is a horrible thing) and thought they'd also access CBMEM, but it looks like they do not.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/77166?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6d65ca51c863abe2106f794398ddd7d7d9ac4b5e
Gerrit-Change-Number: 77166
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jakub Czapiga czapiga@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Mon, 30 Oct 2023 23:57:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment