Change in ...coreboot[master]: google/kukui: Enable config for coreboot display

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

yongqiang niu (Code Review)

20 Feb 2019 20 Feb '19

12:51 p.m.

yongqiang niu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31521

Change subject: google/kukui: Enable config for coreboot display ......................................................................

google/kukui: Enable config for coreboot display

BUG=b:80501386,b:117254947 BRANCH=none TEST=Boots correctly on Kukui

Change-Id: I478e06686158dd77b075bcef8a41763ae26c79f9 Signed-off-by: Yongqiang Niu yongqiang.niu@mediatek.com --- M src/mainboard/google/kukui/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/31521/1

diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 9f477e5..9d2634a 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -37,6 +37,9 @@ select EC_GOOGLE_CHROMEEC_SPI select MAINBOARD_HAS_SPI_TPM_CR50 if VBOOT select MAINBOARD_HAS_TPM2 if VBOOT + select MAINBOARD_HAS_NATIVE_VGA_INIT + select MAINBOARD_FORCE_NATIVE_VGA_INIT + select HAVE_LINEAR_FRAMEBUFFER

config MAINBOARD_DIR string

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Paul Menzel (Code Review)

23 Feb 23 Feb

10:05 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31521 )

Change subject: google/kukui: Enable config for coreboot display ......................................................................

Patch Set 1:

Shouldn’t that be added after the driver is added, so the commit ordering be changed?

-- To view, visit https://review.coreboot.org/c/coreboot/+/31521 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I478e06686158dd77b075bcef8a41763ae26c79f9 Gerrit-Change-Number: 31521 Gerrit-PatchSet: 1 Gerrit-Owner: yongqiang niu yongqiang.niu@mediatek.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Daisuke Nojiri dnojiri@chromium.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 23 Feb 2019 09:05:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

10 Apr 10 Apr

9:26 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31521 )

Change subject: google/kukui: Enable config for coreboot display ......................................................................

Patch Set 3:

Agree with Paul's comments. @ongqiang, can you move this to latter in the chain? We should add drivers first and then enable config, unless if something will break in compilation.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31521 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I478e06686158dd77b075bcef8a41763ae26c79f9 Gerrit-Change-Number: 31521 Gerrit-PatchSet: 3 Gerrit-Owner: yongqiang niu yongqiang.niu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Daisuke Nojiri dnojiri@chromium.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 10 Apr 2019 07:26:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

20 Jul 20 Jul

6:11 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable config for coreboot display

Hung-Te Lin has uploaded a new patch set (#15) to the change originally created by yongqiang niu. ( https://review.coreboot.org/c/coreboot/+/31521 )

Change subject: mb/google/kukui: Enable config for coreboot display ......................................................................

mb/google/kukui: Enable config for coreboot display

BUG=b:80501386,b:117254947 BRANCH=none TEST=Boots correctly on Kukui

Change-Id: I478e06686158dd77b075bcef8a41763ae26c79f9 Signed-off-by: Yongqiang Niu yongqiang.niu@mediatek.com --- M src/mainboard/google/kukui/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/31521/15

-- To view, visit https://review.coreboot.org/c/coreboot/+/31521 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I478e06686158dd77b075bcef8a41763ae26c79f9 Gerrit-Change-Number: 31521 Gerrit-PatchSet: 15 Gerrit-Owner: yongqiang niu yongqiang.niu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Daisuke Nojiri dnojiri@chromium.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: SJ Huang sj.huang@mediatek.corp-partner.google.com Gerrit-MessageType: newpatchset

Hung-Te Lin (Code Review)

23 Jul 23 Jul

3:07 p.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable config for coreboot display

Hung-Te Lin has uploaded a new patch set (#17) to the change originally created by yongqiang niu. ( https://review.coreboot.org/c/coreboot/+/31521 )

Change subject: mb/google/kukui: Enable config for coreboot display ......................................................................

mb/google/kukui: Enable config for coreboot display

BUG=b:80501386,b:117254947 BRANCH=none TEST=Boots correctly on Kukui

Change-Id: I478e06686158dd77b075bcef8a41763ae26c79f9 Signed-off-by: Yongqiang Niu yongqiang.niu@mediatek.com --- M src/mainboard/google/kukui/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/31521/17

-- To view, visit https://review.coreboot.org/c/coreboot/+/31521 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I478e06686158dd77b075bcef8a41763ae26c79f9 Gerrit-Change-Number: 31521 Gerrit-PatchSet: 17 Gerrit-Owner: yongqiang niu yongqiang.niu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Daisuke Nojiri dnojiri@chromium.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: SJ Huang sj.huang@mediatek.corp-partner.google.com Gerrit-MessageType: newpatchset

Hung-Te Lin (Code Review)

25 Jul 25 Jul

2:33 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable config for coreboot display

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31521 )

Change subject: mb/google/kukui: Enable config for coreboot display ......................................................................

Patch Set 20: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31521 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I478e06686158dd77b075bcef8a41763ae26c79f9 Gerrit-Change-Number: 31521 Gerrit-PatchSet: 20 Gerrit-Owner: yongqiang niu yongqiang.niu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Daisuke Nojiri dnojiri@chromium.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: SJ Huang sj.huang@mediatek.corp-partner.google.com Gerrit-Comment-Date: Thu, 25 Jul 2019 00:33:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Julius Werner (Code Review)

31 Jul 31 Jul

6:25 a.m.

New subject: Change in coreboot[master]: mb/google/kukui: Enable config for coreboot display

Julius Werner has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31521 )

Change subject: mb/google/kukui: Enable config for coreboot display ......................................................................

mb/google/kukui: Enable config for coreboot display

BUG=b:80501386,b:117254947 BRANCH=none TEST=Boots correctly on Kukui

Change-Id: I478e06686158dd77b075bcef8a41763ae26c79f9 Signed-off-by: Yongqiang Niu yongqiang.niu@mediatek.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31521 Reviewed-by: Hung-Te Lin hungte@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kukui/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved

diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index fc86972..863f49e 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -38,6 +38,9 @@ select EC_GOOGLE_CHROMEEC_SPI select MAINBOARD_HAS_SPI_TPM_CR50 if VBOOT select MAINBOARD_HAS_TPM2 if VBOOT + select MAINBOARD_HAS_NATIVE_VGA_INIT + select MAINBOARD_FORCE_NATIVE_VGA_INIT + select HAVE_LINEAR_FRAMEBUFFER

config MAINBOARD_DIR string

-- To view, visit https://review.coreboot.org/c/coreboot/+/31521 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I478e06686158dd77b075bcef8a41763ae26c79f9 Gerrit-Change-Number: 31521 Gerrit-PatchSet: 22 Gerrit-Owner: yongqiang niu yongqiang.niu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: You-Cheng Syu youcheng@google.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-CC: Daisuke Nojiri dnojiri@chromium.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: SJ Huang sj.huang@mediatek.corp-partner.google.com Gerrit-MessageType: merged

1725

days inactive

1886

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Hung-Te Lin (Code Review)
Julius Werner (Code Review)
Paul Menzel (Code Review)
yongqiang niu (Code Review)