Attention is currently required from: Rex-BC Chen, Paul Menzel, Yu-Ping Wu. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60833 )
Change subject: soc/mediatek/mt8186: revise wrong setting of devapc ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60833/comment/0e8af188_df4dc4e0 PS3, Line 7: revise if this is fixing something then it's fix instead of revise.
maybe
fix incorrect devapc settings
https://review.coreboot.org/c/coreboot/+/60833/comment/cc6e6126_80e90f23 PS3, Line 9: We need to protect debugsys for firmware image without serial console. : Original settings for protecting debugsys is wrong which will cause some : hardware modules failed to set their registers correctly. can you explain why moving it from one function to another is the right fix?